Skip to content

refactor(delay): delayed messages are now handled in adapters#277

Merged
viktorprogger merged 2 commits intomasterfrom
delay-yo-envelopes
May 1, 2026
Merged

refactor(delay): delayed messages are now handled in adapters#277
viktorprogger merged 2 commits intomasterfrom
delay-yo-envelopes

Conversation

@viktorprogger
Copy link
Copy Markdown
Contributor

@viktorprogger viktorprogger commented May 1, 2026

Q A
Is bugfix?
New feature?
Breaks BC? ✔️
Tests pass? ✔️
Fixed issues

@viktorprogger viktorprogger requested review from samdark and vjik May 1, 2026 14:56
@viktorprogger viktorprogger self-assigned this May 1, 2026
@viktorprogger viktorprogger changed the title refactor(delay): delayed messages are now handled in adapters, fail s… refactor(delay): delayed messages are now handled in adapters May 1, 2026
{
public const META_DELAY_SECONDS = 'yii-delay';

public function __construct(MessageInterface $message, private readonly float $delaySeconds)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why float? Sub-second delay is likely unnecessary.

@viktorprogger viktorprogger merged commit c5a8c24 into master May 1, 2026
2 checks passed
@viktorprogger viktorprogger deleted the delay-yo-envelopes branch May 1, 2026 20:32
@viktorprogger viktorprogger added the status:code review The pull request needs review. label May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants