Skip to content

Use mixed as push middleware definition format#286

Merged
vjik merged 2 commits intomasterfrom
middleware-definition-format
May 6, 2026
Merged

Use mixed as push middleware definition format#286
vjik merged 2 commits intomasterfrom
middleware-definition-format

Conversation

@vjik
Copy link
Copy Markdown
Member

@vjik vjik commented May 5, 2026

Q A
Is bugfix?
New feature?
Breaks BC?
Tests pass? ✔️

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.28%. Comparing base (5e9818c) to head (7cace45).

Files with missing lines Patch % Lines
src/Debug/QueueDecorator.php 0.00% 2 Missing ⚠️
src/Middleware/Push/PushMiddlewareFactory.php 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #286      +/-   ##
============================================
- Coverage     98.39%   98.28%   -0.12%     
- Complexity      324      327       +3     
============================================
  Files            48       48              
  Lines           873      875       +2     
============================================
+ Hits            859      860       +1     
- Misses           14       15       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vjik vjik requested a review from a team May 5, 2026 13:29
@vjik vjik added the status:code review The pull request needs review. label May 5, 2026
@vjik vjik merged commit f3c55b1 into master May 6, 2026
27 of 29 checks passed
@vjik vjik deleted the middleware-definition-format branch May 6, 2026 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants