Open
Conversation
Collaborator
|
I recommend splitting this PR into two. This PR can focus on LoRA and a new one on the additional changes and bug fixes. |
prishajain1
force-pushed
the
ltx2_lora
branch
3 times, most recently
from
e9c9610 to
ff23ced
Compare
Collaborator
Author
Removing changes from this PR for those additional changes seems to be cumbersome. We can wait for #373 PR to be merged (which separates out the additional changes), post which we can push this PR ahead. |
prishajain1
force-pushed
the
ltx2_lora
branch
2 times, most recently
from
2f7a594 to
61a2de6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds LoRA inference support for the LTX2 model in MaxDiffusion
New Files Added
ltx2_lora_nnx_loader.py: A new loader that handles loading and merging LoRA weights for both the central Transformer and the Connectors, including prefix-based log filtering.Files Modified
lora_conversion_utils.py: Added the complete key mapping and path translation logic required for LTX2 LoRA keys.ltx2_video.yml: Added LoRA configuration related paramsResults