Closed
Conversation
etpinard
reviewed
Dec 6, 2017
src/plot_api/subroutines.js
Outdated
| x: fullLayout.title.x, | ||
| y: fullLayout.title.y, | ||
| 'text-anchor': 'start', | ||
| 'dominant-baseline': 'hanging' |
There was a problem hiding this comment.
Hmm. Does dominant-baseline work in all browsers?
Owner
Author
There was a problem hiding this comment.
Got it, will fix it together with other changes from plotly#882
AlexVvx
force-pushed
the
chart-title-alignment
branch
from
2e4c4b9 to
3ac4f0f
Compare
|
Why is it still an open issue? : o |
Collaborator
|
@ewirth I don't recall the details at this point, but we ended up doing this in a slightly different way, in plotly#3276 - so this PR, while useful for advancing the discussion, was ultimately not used directly. @AlexVvx can we close it? |
Owner
Author
|
Yep, let's close |
|
@AlexVvx Thanks for the notice. I think that it's still impossible to set the title to the bottom of a line figure. Or I haven't find it. It should be a easy thing like position: bottom :d |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #882
This PR adds chart title alignment feature. The purpose of feature is to let users adjust the look of chart by using alignment. When there are lots of traces, then legend occupies much space and with center aligned title top margin looks ugly (details in plotly/plotly.R#812)
Title is an object in layout:
text - is title text
alignment - is string (top, bottom, left, right, middle default), small gap between border and title equal to half of text height
x,y - is numbers, manual position in pixels from left top