[WIP] Antalya 26.1; Remote initiator improvements 2 by ianton-ru · Pull Request #1608 · Altinity/ClickHouse

ianton-ru · 2026-04-01T09:10:25Z

Changelog category (leave one):

Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Use object_storage_remote_initiator without object_storage_cluster on initial node.

Documentation entry for user-facing changes

Solved #1607
Query with object_storage_remote_initiator and object_storage_remote_initiator_cluster can be executed, when object_storage_cluster setting is defined only on remote node.

SELECT * FROM datalake.`iceberg.table` SETTINGS object_storage_remote_initiator=1, object_storage_remote_initiator_cluster='swarm_external_name'

converted to

SELECT * FROM remote('random_node_from_swarm_external_name', iceberg(...))

Remote node random_node_from_swarm_external_name executes

SELECT* FROM iceberg(...)

locally of as cluster table function depend on object_storage_cluster defined only on this node.

CI/CD Options

Exclude tests:

Regression jobs to run:

ianton-ru · 2026-04-01T09:10:41Z

@codex review

github-actions · 2026-04-01T09:11:34Z

Workflow [PR], commit [b1efb77]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6a03617679

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-01T09:22:58Z

src/TableFunctions/TableFunctionObjectStorageClusterFallback.cpp

    const auto & settings = context->getSettingsRef();

-    is_cluster_function = !settings[Setting::object_storage_cluster].value.empty() && typename Base::Configuration().isClusterSupported();
+    is_cluster_function = typename Base::Configuration().isClusterSupported();


Preserve simple-mode fallback when no cluster is configured

Assigning is_cluster_function from Base::Configuration().isClusterSupported() unconditionally forces s3(...)/iceberg(...) fallback functions into cluster mode even when object_storage_cluster is empty. In the CREATE TABLE ... AS <table_function> path, arguments are parsed before validateUseToCreateTable() is called, so this change now makes validateUseToCreateTable() throw for previously valid non-cluster statements like CREATE TABLE t AS s3(...). Please keep cluster mode gated by an actual configured cluster name (or a narrower remote-initiator condition) to avoid regressing non-cluster table-function creation.

Useful? React with 👍 / 👎.

ianton-ru · 2026-04-01T11:27:54Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ed463afe38

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-01T11:39:31Z

src/Storages/ObjectStorage/StorageObjectStorageCluster.cpp

+    if (make_cluster_function)
    {


Set cluster_name_in_settings on non-cluster rewrite

When make_cluster_function is false, this branch now skips setting cluster_name_in_settings, but updateQueryToSendIfNeeded() still uses that flag to decide whether the first argument is a cluster name (extractDynamicStorageType(..., !cluster_name_in_settings)). For engine-to-function rewrites in the new remote-initiator-without-local-cluster flow, this misclassifies the first real argument as a cluster name, so named-collection-based data lake queries can lose storage_type detection and fall back to S3 semantics on the remote side.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-01T11:39:31Z

src/TableFunctions/TableFunctionObjectStorageClusterFallback.cpp

+    is_cluster_function = (!settings[Setting::object_storage_cluster].value.empty() ||  !settings[Setting::object_storage_remote_initiator_cluster].value.empty())
+        && typename Base::Configuration().isClusterSupported();


Gate cluster fallback on remote initiator being enabled

This condition now flips to cluster-mode parsing whenever object_storage_remote_initiator_cluster is set, even if object_storage_remote_initiator is disabled. That changes plain s3/iceberg/... table-function behavior globally for sessions that carry only the cluster-name setting (for example from a profile), and can trigger cluster-only restrictions such as validateUseToCreateTable() rejecting create-table usage unexpectedly.

Useful? React with 👍 / 👎.

ianton-ru · 2026-04-01T14:28:22Z

@codex review

chatgpt-codex-connector · 2026-04-01T14:53:48Z

Codex Review: Didn't find any major issues. What shall we delve into next?

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ianton-ru · 2026-04-01T16:02:42Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b1efb77d2a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-01T16:18:56Z

src/Storages/IStorageCluster.cpp

+    const auto & settings = context->getSettingsRef();
+    ASTPtr query_to_send = query_info.query;

    if (!isClusterSupported() || cluster_name_from_settings.empty())


Exclude non-cluster storages from remote-initiator rewrite

The new if (!isClusterSupported() || cluster_name_from_settings.empty()) branch now routes object_storage_remote_initiator=1 queries through updateQueryToSendIfNeeded(..., make_cluster_function=false) even when the storage explicitly reports isClusterSupported()==false. For datalake configs like StorageLocalPaimonConfiguration (used by PaimonLocal), StorageObjectStorageCluster::updateQueryForDistributedEngineIfNeeded cannot map the engine name (PaimonLocal) to a table function and throws a logical error before the remote call is built. Previously these queries fell back to pure local read; now they fail whenever remote initiator is enabled.

Useful? React with 👍 / 👎.

ianton-ru added 2 commits March 31, 2026 18:58

allow object_storage_remote_initiator with non-cluster function

e1286a9

Merge antalya-26.1

6a03617

ianton-ru changed the title ~~Antalya 26.1; Remote initiator improvements 2~~ [WIP] Antalya 26.1; Remote initiator improvements 2 Apr 1, 2026

chatgpt-codex-connector bot reviewed Apr 1, 2026

View reviewed changes

ianton-ru force-pushed the feature/antalya-26.1/remote_initiator_improvements_2 branch from ed463af to c60f71f Compare April 1, 2026 14:27

Fix

b1efb77

ianton-ru force-pushed the feature/antalya-26.1/remote_initiator_improvements_2 branch from c60f71f to b1efb77 Compare April 1, 2026 15:42

chatgpt-codex-connector bot reviewed Apr 1, 2026

View reviewed changes

		is_cluster_function = (!settings[Setting::object_storage_cluster].value.empty() \|\| !settings[Setting::object_storage_remote_initiator_cluster].value.empty())
		&& typename Base::Configuration().isClusterSupported();

Conversation

ianton-ru commented Apr 1, 2026

Changelog category (leave one):

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Documentation entry for user-facing changes

CI/CD Options

Exclude tests:

Regression jobs to run:

Uh oh!

ianton-ru commented Apr 1, 2026

Uh oh!

github-actions bot commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

ianton-ru commented Apr 1, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

ianton-ru commented Apr 1, 2026

Uh oh!

chatgpt-codex-connector bot commented Apr 1, 2026

Uh oh!

ianton-ru commented Apr 1, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

github-actions bot commented Apr 1, 2026 •

edited

Loading