fix: skip ignored members before reading source property#104
Merged
Conversation
Ignored members were triggering spurious WARNING logs ("Cannot access
source property") when the corresponding property did not exist on the
source object. The isIgnored() check only existed inside
memberDestinationValuePut(), which was never reached when the source
read failed. Move the check to the top of the mapping loop so ignored
members are skipped before any source access attempt.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WARNINGlogs ("Cannot access source property") emitted for every mapping member marked withignore()when the corresponding property doesn't exist on the source objectisIgnored()check to the top of the mapping loop inmapType(), beforememberSourceValueFor()is calledisIgnored()guard insidememberDestinationValuePut()Root cause
The mapping loop in
AutoMapper::mapType()iterated all destination members and immediately attempted to read the source property. TheisIgnored()check only existed insidememberDestinationValuePut(), which was never reached when the source read failed — causing a warning +continueon every ignored member without a matching source property.Test plan
testIgnoredMemberWithNoSourcePropertyDoesNotLogWarning— verifies no warning is logged for ignored members with missing source propertiestestIgnoredMemberSkipsSourceReadAndDestinationWrite— verifies ignored members retain their default value when usingmap()🤖 Generated with Claude Code