Skip to content

AP-487: declare correct mime type for HLS streams#17

Merged
anarchivist merged 3 commits intomainfrom
AP-487
Nov 6, 2025
Merged

AP-487: declare correct mime type for HLS streams#17
anarchivist merged 3 commits intomainfrom
AP-487

Conversation

@anarchivist
Copy link
Copy Markdown
Member

our declaration of the HLS mimetype in the <video> and <audio> elements is incorrect. the audio and video partials declare it as application/x-mpegURL, the correct mime type is application/vnd.apple.mpegurl according to the HLS spec.

our declaration of the HLS mimetype in the `<video>` and `<audio>` elements is
incorrect. the audio and video partials declare it as `application/x-mpegURL`,
the correct mime type is `application/vnd.apple.mpegurl` according to the
[HLS spec](https://datatracker.ietf.org/doc/html/draft-pantos-hls-rfc8216bis-18).
@jason-raitz
Copy link
Copy Markdown
Contributor

There are some mentions of x-mpegurl in av-core as well. Should we go through and update those?

@anarchivist
Copy link
Copy Markdown
Member Author

@jason-raitz yep, i'll go and submit a PR now

@anarchivist
Copy link
Copy Markdown
Member Author

@jason-raitz actually, as it turns out, av-core is differently wrong 🙃 i'll submit a pr there anyway

anarchivist added a commit to BerkeleyLibrary/av-core that referenced this pull request Nov 6, 2025
identified in code review of BerkeleyLibrary/avplayer#17. the declared
mime types as specified for FileType::MP3 erroneously are using the
mime type for m3u8 playlists instead of the correct mime type for
mp3 data.
Copy link
Copy Markdown
Member

@awilfox awilfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. r+

@anarchivist anarchivist merged commit b872878 into main Nov 6, 2025
5 checks passed
@anarchivist anarchivist deleted the AP-487 branch November 6, 2025 00:53
anarchivist added a commit to BerkeleyLibrary/av-core that referenced this pull request Nov 6, 2025
identified in code review of BerkeleyLibrary/avplayer#17. the declared
mime types as specified for FileType::MP3 erroneously are using the
mime type for m3u8 playlists instead of the correct mime type for
mp3 data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants