Skip to content

Minor wording update - Select models to make public -> Update model public status#24725

Open
RoyVivat wants to merge 1 commit intoBerriAI:mainfrom
RoyVivat:update_make_model_public_wording
Open

Minor wording update - Select models to make public -> Update model public status#24725
RoyVivat wants to merge 1 commit intoBerriAI:mainfrom
RoyVivat:update_make_model_public_wording

Conversation

@RoyVivat
Copy link
Copy Markdown

Relevant issues

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have Added testing in the tests/test_litellm/ directory, Adding at least 1 test is a hard requirement - see details
  • My PR passes all unit tests on make test-unit
  • My PR's scope is as isolated as possible, it only solves 1 specific problem
  • I have requested a Greptile review by commenting @greptileai and received a Confidence Score of at least 4/5 before requesting a maintainer review

Delays in PR merge?

If you're seeing a delay in your PR being merged, ping the LiteLLM Team on Slack (#pr-review).

CI (LiteLLM team)

CI status guideline:

  • 50-55 passing tests: main is stable with minor issues.
  • 45-49 passing tests: acceptable but needs attention
  • <= 40 passing tests: unstable; be careful with your merges and assess the risk.
  • Branch creation CI run
    Link:

  • CI run for the last commit
    Link:

  • Merge / cherry-pick CI run
    Links:

Type

🆕 New Feature
🐛 Bug Fix
🧹 Refactoring
📖 Documentation
🚄 Infrastructure
✅ Test

Changes

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
litellm Ready Ready Preview, Comment Mar 28, 2026 6:50am

Request Review

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codspeed-hq
Copy link
Copy Markdown
Contributor

codspeed-hq Bot commented Mar 28, 2026

Merging this PR will not alter performance

✅ 16 untouched benchmarks


Comparing RoyVivat:update_make_model_public_wording (4041afe) with main (fe080a8)

Open in CodSpeed

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Mar 28, 2026

Greptile Summary

This PR makes a minor cosmetic wording update to MakeModelPublicForm.tsx, changing the step-1 panel heading from "Select Models to Make Public" to "Update Model Public Status". No logic, API calls, state management, or component behavior is affected.

  • Only one line changed (<Title> text in renderStep1Content)
  • No tests added or modified
  • No functional impact; purely a UI label update

Confidence Score: 5/5

  • Safe to merge — purely a one-line UI label change with no logic or behavioral impact.
  • The entire diff is a single title string update. No API calls, state, tests, or component logic are touched, making this a zero-risk change.
  • No files require special attention.

Important Files Changed

Filename Overview
ui/litellm-dashboard/src/components/AIHub/forms/MakeModelPublicForm.tsx Single-line title text change from "Select Models to Make Public" to "Update Model Public Status"; no logic, behavior, or API changes.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A([Open Modal\n'Make Models Public']) --> B[Step 1: 'Update Model Public Status'\nSelect models to make public]
    B --> C{At least one\nmodel selected?}
    C -- No --> D[Show validation error]
    C -- Yes --> E[Step 2: Confirm Making Models Public]
    E --> F[Submit → makeModelGroupPublic API\n/model_group/make_public]
    F --> G([Success notification\nClose modal])
Loading

Reviews (2): Last reviewed commit: "updated wording" | Re-trigger Greptile

<div className="space-y-4">
<div className="flex items-center justify-between">
<Title>Select Models to Make Public</Title>
<Title>Update Model Public Status</Title>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Title implies bidirectional toggle, but the API is unidirectional (make-public only)

The new title "Update Model Public Status" implies users can both make models public and make them private by toggling checkboxes. However, the underlying makeModelGroupPublic function only calls the /model_group/make_public endpoint — there is no corresponding call to make deselected models private.

Looking at networking.tsx:

export const makeModelGroupPublic = async (accessToken: string, modelGroups: string[]) => {
  const url = proxyBaseUrl ? `${proxyBaseUrl}/model_group/make_public` : `/model_group/make_public`;
  // ...
  body: JSON.stringify({ model_groups: modelGroups }),
};

And in handleSubmit:

const modelGroupsToMakePublic = Array.from(selectedModels);
await makeModelGroupPublic(accessToken, modelGroupsToMakePublic);
NotificationsManager.success(`Successfully made ${modelGroupsToMakePublic.length} model group(s) public!`);

The form pre-selects already-public models (via useEffect at line 103–107), creating the illusion that unchecking them will make them private. But submitting only sends the currently-selected models to a "make public" endpoint — deselected previously-public models are silently left public.

If the intent of the rename is to surface bidirectional capability, the backend API must also be updated to handle making models private for omitted groups. If the operation is truly unidirectional, the old title was more accurate and should be reverted (or corrected to something that doesn't imply a toggle).

@RoyVivat
Copy link
Copy Markdown
Author

@greptileai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants