Minor wording update - Select models to make public -> Update model public status#24725
Minor wording update - Select models to make public -> Update model public status#24725RoyVivat wants to merge 1 commit intoBerriAI:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
Greptile SummaryThis PR makes a minor cosmetic wording update to
Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| ui/litellm-dashboard/src/components/AIHub/forms/MakeModelPublicForm.tsx | Single-line title text change from "Select Models to Make Public" to "Update Model Public Status"; no logic, behavior, or API changes. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A([Open Modal\n'Make Models Public']) --> B[Step 1: 'Update Model Public Status'\nSelect models to make public]
B --> C{At least one\nmodel selected?}
C -- No --> D[Show validation error]
C -- Yes --> E[Step 2: Confirm Making Models Public]
E --> F[Submit → makeModelGroupPublic API\n/model_group/make_public]
F --> G([Success notification\nClose modal])
Reviews (2): Last reviewed commit: "updated wording" | Re-trigger Greptile
| <div className="space-y-4"> | ||
| <div className="flex items-center justify-between"> | ||
| <Title>Select Models to Make Public</Title> | ||
| <Title>Update Model Public Status</Title> |
There was a problem hiding this comment.
Title implies bidirectional toggle, but the API is unidirectional (make-public only)
The new title "Update Model Public Status" implies users can both make models public and make them private by toggling checkboxes. However, the underlying makeModelGroupPublic function only calls the /model_group/make_public endpoint — there is no corresponding call to make deselected models private.
Looking at networking.tsx:
export const makeModelGroupPublic = async (accessToken: string, modelGroups: string[]) => {
const url = proxyBaseUrl ? `${proxyBaseUrl}/model_group/make_public` : `/model_group/make_public`;
// ...
body: JSON.stringify({ model_groups: modelGroups }),
};And in handleSubmit:
const modelGroupsToMakePublic = Array.from(selectedModels);
await makeModelGroupPublic(accessToken, modelGroupsToMakePublic);
NotificationsManager.success(`Successfully made ${modelGroupsToMakePublic.length} model group(s) public!`);The form pre-selects already-public models (via useEffect at line 103–107), creating the illusion that unchecking them will make them private. But submitting only sends the currently-selected models to a "make public" endpoint — deselected previously-public models are silently left public.
If the intent of the rename is to surface bidirectional capability, the backend API must also be updated to handle making models private for omitted groups. If the operation is truly unidirectional, the old title was more accurate and should be reverted (or corrected to something that doesn't imply a toggle).
Relevant issues
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/test_litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unit@greptileaiand received a Confidence Score of at least 4/5 before requesting a maintainer reviewDelays in PR merge?
If you're seeing a delay in your PR being merged, ping the LiteLLM Team on Slack (#pr-review).
CI (LiteLLM team)
Branch creation CI run
Link:
CI run for the last commit
Link:
Merge / cherry-pick CI run
Links:
Type
🆕 New Feature
🐛 Bug Fix
🧹 Refactoring
📖 Documentation
🚄 Infrastructure
✅ Test
Changes