Don't upload addresses as they appear#1600
Merged
PeterSurda merged 1 commit intoBitmessage:v0.6from Feb 5, 2020
Merged
Conversation
Member
PeterSurda
commented
Feb 5, 2020
PeterSurda
commented
- attempt to fix Excessive memory usage #1598
- seems to work
- addresses won't be uploaded/announced anymore other than after connecting, Later I need to find out how to announce them without causing problems, but for the time disabling this seems an acceptable drawback
PeterSurda
force-pushed
the
addr-memleak-fix-1
branch
3 times, most recently
from
f35ffe2 to
b9d5eda
Compare
Collaborator
|
Why don't you just comment the line where the peers are put into |
Member
Author
|
I suppose that's also an approach. |
PeterSurda
force-pushed
the
addr-memleak-fix-1
branch
from
b9d5eda to
97bf4f9
Compare
- attempt to fix Bitmessage#1598 - seems to work - addresses won't be uploaded/announced anymore other than after connecting, Later I need to find out how to announce them without causing problems, but for the time disabling this seems an acceptable drawback
PeterSurda
force-pushed
the
addr-memleak-fix-1
branch
from
97bf4f9 to
11bec55
Compare
Member
Author
|
there you go |
g1itch
approved these changes
Feb 5, 2020
Collaborator
g1itch
left a comment
g1itch
left a comment
There was a problem hiding this comment.
My problem with this is that I cannot reproduce the memleak. mprof doesn't show a substantial memory usage growth. ~ 5 MB difference that I can see may be caused by different number of connections in different lunches.
Member
Author
|
I tested it on one of the bootstrap servers, you probably need many incoming connections and it still takes a couple of hours to trigger, even a day. Then the memory consumption starts growing until it fills up and swap starts thrashing. Now it's been running for about 2 days without any issues (with the fix). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.