Skip to content

renderer: disable ARB_shader_draw_parameters on GLSL 1.20#1576

Merged
illwieckz merged 1 commit intomasterfrom
illwieckz/material-enablement
Mar 5, 2025
Merged

renderer: disable ARB_shader_draw_parameters on GLSL 1.20#1576
illwieckz merged 1 commit intomasterfrom
illwieckz/material-enablement

Conversation

@illwieckz
Copy link
Copy Markdown
Member

@illwieckz illwieckz commented Mar 4, 2025

@VReaperV
Copy link
Copy Markdown
Contributor

VReaperV commented Mar 4, 2025

How about just disabling the extension on version 120? I think that would be a cleaner approach.

@illwieckz illwieckz changed the title renderer: disable the material system on GLSL 1.20 and do not generate some GLSL code when disabled renderer: disable ARB_shader_draw_parameters on GLSL 1.20 Mar 5, 2025
@illwieckz illwieckz force-pushed the illwieckz/material-enablement branch from 9f565c3 to 1c806ec Compare March 5, 2025 11:44
@illwieckz
Copy link
Copy Markdown
Member Author

How about just disabling the extension on version 120? I think that would be a cleaner approach.

That was my first implementation but then I thought this would be better instead. 🤭️

I reverted to disabling the extension on version 120.

@illwieckz illwieckz force-pushed the illwieckz/material-enablement branch from 1c806ec to 4686134 Compare March 5, 2025 12:58
Copy link
Copy Markdown
Contributor

@VReaperV VReaperV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking, might want to name all of these as *ShaderDrawParameters for consistency (and with camelCase for variables).

LGTM.

@illwieckz illwieckz force-pushed the illwieckz/material-enablement branch from 4686134 to 4488430 Compare March 5, 2025 16:22
@illwieckz
Copy link
Copy Markdown
Member Author

Non-blocking, might want to name all of these as *ShaderDrawParameters for consistency (and with camelCase for variables).

Good catch, fixed.

@illwieckz illwieckz merged commit 62d591d into master Mar 5, 2025
9 checks passed
@illwieckz illwieckz deleted the illwieckz/material-enablement branch March 5, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some material shader code is built even when glConfig2.usingMaterialSystem is false

2 participants