R_FindCubeImage: avoid the boring “Failed to open” on skybox format try#178
Merged
illwieckz merged 6 commits intoDaemonEngine:masterfrom Mar 6, 2019
Merged
R_FindCubeImage: avoid the boring “Failed to open” on skybox format try#178illwieckz merged 6 commits intoDaemonEngine:masterfrom
illwieckz merged 6 commits intoDaemonEngine:masterfrom
Conversation
slipher
reviewed
Mar 5, 2019
Member
slipher
left a comment
slipher
left a comment
There was a problem hiding this comment.
Looks solid, just some style issues.
illwieckz
force-pushed
the
skywarning
branch
2 times, most recently
from
ec2bf88 to
728eb18
Compare
I see no need to priorize dds/%s.dds over other formats in anyway, it's a compatibility layer after all
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to avoid those boring, false-positive debug messages:
Note that the
R_FindImageLoadercode (first two commits) is the one I first pushed in #159.If first worked on
R_FindImageLoaderfor the need of the removal of this debug message, but working on Xonotic stuff was more exciting. 😛This is better to merge this first, as the image commits will be together, and then the dpMaterial PR would just be 1 commit.