Skip to content

renderer: some minor improvements (factorisation etc.)#300

Merged
illwieckz merged 3 commits intoDaemonEngine:masterfrom
illwieckz:polishing
Apr 11, 2020
Merged

renderer: some minor improvements (factorisation etc.)#300
illwieckz merged 3 commits intoDaemonEngine:masterfrom
illwieckz:polishing

Conversation

@illwieckz
Copy link
Copy Markdown
Member

@illwieckz illwieckz commented Mar 9, 2020

  • Move reflective specular computation in specular computation in computeLight glsl file.
  • Move lightGrid color computation in computeLight file to avoid copy paste.
  • Move blending after the test to discard fragment based on alpha (do not blend what would be discarded).

@illwieckz
Copy link
Copy Markdown
Member Author

illwieckz commented Mar 9, 2020 •
edited
Loading

This is Spartaa!!

@illwieckz illwieckz mentioned this pull request Mar 9, 2020
Merged
slipher
slipher reviewed Mar 30, 2020
View reviewed changes
slipher
slipher approved these changes Mar 30, 2020
View reviewed changes
@illwieckz illwieckz merged commit 6b89849 into DaemonEngine:master Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slipher slipher slipher approved these changes

Assignees

No one assigned

Labels

A-Renderer T-Cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@illwieckz @slipher