Skip to content

shaders: Remove some ET only shaders.#661

Merged
DolceTriade merged 1 commit intomasterfrom
ishq/delspam
Jul 29, 2022
Merged

shaders: Remove some ET only shaders.#661
DolceTriade merged 1 commit intomasterfrom
ishq/delspam

Conversation

@DolceTriade
Copy link
Copy Markdown
Contributor

Remove sunShader and flareShader. They are only used in ET and not
actually used anywhere in the engine. They just spam us.

Remove sunShader and flareShader. They are only used in ET and not
actually used anywhere in the engine. They just spam us.
@slipher
Copy link
Copy Markdown
Member

slipher commented Jul 29, 2022

LGTM

@DolceTriade DolceTriade merged commit 8a7fb7f into master Jul 29, 2022
@illwieckz
Copy link
Copy Markdown
Member

For information if we want to reimplement them the missing images can be found in XreaL (old zip release, not repository).

@illwieckz
Copy link
Copy Markdown
Member

illwieckz commented Jul 29, 2022

Si I looked at the code and even the RB_DrawSun function is missing from our tree.

I sometime have the strong feeling OpenWolf was not forked from latest ET:XreaL…

The sun shader is a special shader to display a sun on the skybox like this (here in ET:Legacy, Oasis map):

Providing the needed assets and setting r_drawSun 1 in Dæmon does nothing (RB_DrawSun function is missing…).

If we want to implement this one day, the data is there (from XreaL_PreAlpha_20080704.7z):

https://dl.illwieckz.net/b/daemon/features/xreal-missing-shaders/engine-xreal_0.dpk

For some unknown reason the data is shipped in XreaL_PreAlpha_20080704.7z but there is no code for it, and the data is not shipped in ETXreaL-0.3.0-20111110 but there is code for it)…

@slipher slipher deleted the ishq/delspam branch July 29, 2022 22:23
@illwieckz
Copy link
Copy Markdown
Member

@DolceTriade you may want to also delete the r_drawSun cvar, that was to enable/disable sunShader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants