Use TagMap.set in CoreTracer tracer tags#11004
Use TagMap.set in CoreTracer tracer tags#11004gh-worker-dd-mergequeue-cf854d[bot] merged 5 commits intomasterfrom
Conversation
Co-authored-by: dougqh <dougqh@gmail.com>
|
Bits Dev status: ✅ Done Comment @DataDog to request changes |
|
I can only run on private repositories. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 67 metrics, 4 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~43abdacafb, baseline=1.61.0-SNAPSHOT~0ee26e896c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1065596
Total [baseline] (8.84 s) : 0, 8839880
Agent [candidate] (1.065 s) : 0, 1065482
Total [candidate] (8.876 s) : 0, 8875647
section iast
Agent [baseline] (1.237 s) : 0, 1236819
Total [baseline] (9.585 s) : 0, 9585004
Agent [candidate] (1.235 s) : 0, 1235233
Total [candidate] (9.588 s) : 0, 9587916
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~43abdacafb, baseline=1.61.0-SNAPSHOT~0ee26e896c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.208 ms) : 0, 1208
BytebuddyAgent [baseline] (633.067 ms) : 0, 633067
BytebuddyAgent [candidate] (634.128 ms) : 0, 634128
AgentMeter [baseline] (29.723 ms) : 0, 29723
AgentMeter [candidate] (29.512 ms) : 0, 29512
GlobalTracer [baseline] (259.21 ms) : 0, 259210
GlobalTracer [candidate] (258.612 ms) : 0, 258612
AppSec [baseline] (32.174 ms) : 0, 32174
AppSec [candidate] (32.149 ms) : 0, 32149
Debugger [baseline] (60.267 ms) : 0, 60267
Debugger [candidate] (60.439 ms) : 0, 60439
Remote Config [baseline] (589.19 µs) : 0, 589
Remote Config [candidate] (592.283 µs) : 0, 592
Telemetry [baseline] (8.168 ms) : 0, 8168
Telemetry [candidate] (8.133 ms) : 0, 8133
Flare Poller [baseline] (5.021 ms) : 0, 5021
Flare Poller [candidate] (4.305 ms) : 0, 4305
section iast
crashtracking [baseline] (1.206 ms) : 0, 1206
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (802.219 ms) : 0, 802219
BytebuddyAgent [candidate] (802.81 ms) : 0, 802810
AgentMeter [baseline] (11.481 ms) : 0, 11481
AgentMeter [candidate] (11.457 ms) : 0, 11457
GlobalTracer [baseline] (249.139 ms) : 0, 249139
GlobalTracer [candidate] (249.178 ms) : 0, 249178
IAST [baseline] (25.764 ms) : 0, 25764
IAST [candidate] (25.458 ms) : 0, 25458
AppSec [baseline] (27.041 ms) : 0, 27041
AppSec [candidate] (26.596 ms) : 0, 26596
Debugger [baseline] (67.651 ms) : 0, 67651
Debugger [candidate] (66.817 ms) : 0, 66817
Remote Config [baseline] (538.264 µs) : 0, 538
Remote Config [candidate] (515.925 µs) : 0, 516
Telemetry [baseline] (11.511 ms) : 0, 11511
Telemetry [candidate] (11.106 ms) : 0, 11106
Flare Poller [baseline] (3.93 ms) : 0, 3930
Flare Poller [candidate] (3.944 ms) : 0, 3944
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~43abdacafb, baseline=1.61.0-SNAPSHOT~0ee26e896c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1063815
Total [baseline] (11.083 s) : 0, 11083187
Agent [candidate] (1.075 s) : 0, 1075185
Total [candidate] (11.05 s) : 0, 11049739
section appsec
Agent [baseline] (1.254 s) : 0, 1254094
Total [baseline] (11.229 s) : 0, 11228936
Agent [candidate] (1.25 s) : 0, 1249913
Total [candidate] (11.1 s) : 0, 11099555
section iast
Agent [baseline] (1.233 s) : 0, 1233389
Total [baseline] (11.353 s) : 0, 11353243
Agent [candidate] (1.242 s) : 0, 1242155
Total [candidate] (11.321 s) : 0, 11321255
section profiling
Agent [baseline] (1.188 s) : 0, 1187671
Total [baseline] (10.962 s) : 0, 10962499
Agent [candidate] (1.194 s) : 0, 1193930
Total [candidate] (11.04 s) : 0, 11039677
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~43abdacafb, baseline=1.61.0-SNAPSHOT~0ee26e896c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.227 ms) : 0, 1227
BytebuddyAgent [baseline] (634.1 ms) : 0, 634100
BytebuddyAgent [candidate] (640.802 ms) : 0, 640802
AgentMeter [baseline] (29.662 ms) : 0, 29662
AgentMeter [candidate] (29.943 ms) : 0, 29943
GlobalTracer [baseline] (258.064 ms) : 0, 258064
GlobalTracer [candidate] (261.019 ms) : 0, 261019
AppSec [baseline] (31.831 ms) : 0, 31831
AppSec [candidate] (32.378 ms) : 0, 32378
Debugger [baseline] (60.548 ms) : 0, 60548
Debugger [candidate] (61.229 ms) : 0, 61229
Remote Config [baseline] (615.037 µs) : 0, 615
Remote Config [candidate] (585.854 µs) : 0, 586
Telemetry [baseline] (8.108 ms) : 0, 8108
Telemetry [candidate] (8.093 ms) : 0, 8093
Flare Poller [baseline] (3.553 ms) : 0, 3553
Flare Poller [candidate] (3.574 ms) : 0, 3574
section appsec
crashtracking [baseline] (1.211 ms) : 0, 1211
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (663.762 ms) : 0, 663762
BytebuddyAgent [candidate] (659.982 ms) : 0, 659982
AgentMeter [baseline] (12.174 ms) : 0, 12174
AgentMeter [candidate] (12.168 ms) : 0, 12168
GlobalTracer [baseline] (258.905 ms) : 0, 258905
GlobalTracer [candidate] (258.476 ms) : 0, 258476
IAST [baseline] (24.247 ms) : 0, 24247
IAST [candidate] (24.139 ms) : 0, 24139
AppSec [baseline] (178.2 ms) : 0, 178200
AppSec [candidate] (178.12 ms) : 0, 178120
Debugger [baseline] (66.632 ms) : 0, 66632
Debugger [candidate] (66.695 ms) : 0, 66695
Remote Config [baseline] (648.351 µs) : 0, 648
Remote Config [candidate] (649.592 µs) : 0, 650
Telemetry [baseline] (8.234 ms) : 0, 8234
Telemetry [candidate] (8.48 ms) : 0, 8480
Flare Poller [baseline] (3.613 ms) : 0, 3613
Flare Poller [candidate] (3.64 ms) : 0, 3640
section iast
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.227 ms) : 0, 1227
BytebuddyAgent [baseline] (800.937 ms) : 0, 800937
BytebuddyAgent [candidate] (807.398 ms) : 0, 807398
AgentMeter [baseline] (11.446 ms) : 0, 11446
AgentMeter [candidate] (11.717 ms) : 0, 11717
GlobalTracer [baseline] (248.406 ms) : 0, 248406
GlobalTracer [candidate] (249.312 ms) : 0, 249312
IAST [baseline] (25.412 ms) : 0, 25412
IAST [candidate] (25.501 ms) : 0, 25501
AppSec [baseline] (26.566 ms) : 0, 26566
AppSec [candidate] (26.766 ms) : 0, 26766
Debugger [baseline] (70.181 ms) : 0, 70181
Debugger [candidate] (70.598 ms) : 0, 70598
Remote Config [baseline] (534.388 µs) : 0, 534
Remote Config [candidate] (537.064 µs) : 0, 537
Telemetry [baseline] (9.215 ms) : 0, 9215
Telemetry [candidate] (9.307 ms) : 0, 9307
Flare Poller [baseline] (3.361 ms) : 0, 3361
Flare Poller [candidate] (3.466 ms) : 0, 3466
section profiling
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (686.485 ms) : 0, 686485
BytebuddyAgent [candidate] (691.276 ms) : 0, 691276
AgentMeter [baseline] (8.991 ms) : 0, 8991
AgentMeter [candidate] (9.103 ms) : 0, 9103
GlobalTracer [baseline] (215.566 ms) : 0, 215566
GlobalTracer [candidate] (215.988 ms) : 0, 215988
AppSec [baseline] (32.42 ms) : 0, 32420
AppSec [candidate] (32.469 ms) : 0, 32469
Debugger [baseline] (66.059 ms) : 0, 66059
Debugger [candidate] (66.239 ms) : 0, 66239
Remote Config [baseline] (568.274 µs) : 0, 568
Remote Config [candidate] (566.486 µs) : 0, 566
Telemetry [baseline] (7.722 ms) : 0, 7722
Telemetry [candidate] (7.776 ms) : 0, 7776
Flare Poller [baseline] (3.488 ms) : 0, 3488
Flare Poller [candidate] (3.557 ms) : 0, 3557
ProfilingAgent [baseline] (94.096 ms) : 0, 94096
ProfilingAgent [candidate] (94.263 ms) : 0, 94263
Profiling [baseline] (94.651 ms) : 0, 94651
Profiling [candidate] (94.821 ms) : 0, 94821
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 17 metrics, 18 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~43abdacafb, baseline=1.61.0-SNAPSHOT~0ee26e896c
dateFormat X
axisFormat %s
section baseline
no_agent (19.197 ms) : 19001, 19394
. : milestone, 19197,
appsec (18.443 ms) : 18254, 18631
. : milestone, 18443,
code_origins (18.072 ms) : 17894, 18251
. : milestone, 18072,
iast (17.927 ms) : 17752, 18102
. : milestone, 17927,
profiling (18.516 ms) : 18331, 18701
. : milestone, 18516,
tracing (17.766 ms) : 17588, 17945
. : milestone, 17766,
section candidate
no_agent (19.163 ms) : 18967, 19360
. : milestone, 19163,
appsec (18.523 ms) : 18334, 18713
. : milestone, 18523,
code_origins (17.631 ms) : 17459, 17803
. : milestone, 17631,
iast (17.796 ms) : 17621, 17971
. : milestone, 17796,
profiling (18.694 ms) : 18507, 18880
. : milestone, 18694,
tracing (17.786 ms) : 17610, 17961
. : milestone, 17786,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~43abdacafb, baseline=1.61.0-SNAPSHOT~0ee26e896c
dateFormat X
axisFormat %s
section baseline
no_agent (1.212 ms) : 1202, 1223
. : milestone, 1212,
iast (3.294 ms) : 3243, 3344
. : milestone, 3294,
iast_FULL (6.135 ms) : 6073, 6198
. : milestone, 6135,
iast_GLOBAL (3.766 ms) : 3702, 3830
. : milestone, 3766,
profiling (2.309 ms) : 2286, 2333
. : milestone, 2309,
tracing (1.886 ms) : 1869, 1903
. : milestone, 1886,
section candidate
no_agent (1.304 ms) : 1289, 1318
. : milestone, 1304,
iast (3.398 ms) : 3351, 3446
. : milestone, 3398,
iast_FULL (5.948 ms) : 5887, 6008
. : milestone, 5948,
iast_GLOBAL (3.699 ms) : 3640, 3759
. : milestone, 3699,
profiling (2.176 ms) : 2154, 2199
. : milestone, 2176,
tracing (1.875 ms) : 1859, 1891
. : milestone, 1875,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~43abdacafb, baseline=1.61.0-SNAPSHOT~0ee26e896c
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (3.835 ms) : 3612, 4058
. : milestone, 3835,
iast (2.272 ms) : 2203, 2342
. : milestone, 2272,
iast_GLOBAL (2.314 ms) : 2244, 2385
. : milestone, 2314,
profiling (2.104 ms) : 2049, 2159
. : milestone, 2104,
tracing (2.07 ms) : 2016, 2124
. : milestone, 2070,
section candidate
no_agent (1.484 ms) : 1473, 1496
. : milestone, 1484,
appsec (3.659 ms) : 3446, 3871
. : milestone, 3659,
iast (2.265 ms) : 2196, 2334
. : milestone, 2265,
iast_GLOBAL (2.317 ms) : 2246, 2387
. : milestone, 2317,
profiling (2.108 ms) : 2051, 2164
. : milestone, 2108,
tracing (2.065 ms) : 2011, 2118
. : milestone, 2065,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~43abdacafb, baseline=1.61.0-SNAPSHOT~0ee26e896c
dateFormat X
axisFormat %s
section baseline
no_agent (15.039 s) : 15039000, 15039000
. : milestone, 15039000,
appsec (14.763 s) : 14763000, 14763000
. : milestone, 14763000,
iast (17.875 s) : 17875000, 17875000
. : milestone, 17875000,
iast_GLOBAL (17.781 s) : 17781000, 17781000
. : milestone, 17781000,
profiling (15.006 s) : 15006000, 15006000
. : milestone, 15006000,
tracing (15.054 s) : 15054000, 15054000
. : milestone, 15054000,
section candidate
no_agent (15.197 s) : 15197000, 15197000
. : milestone, 15197000,
appsec (14.807 s) : 14807000, 14807000
. : milestone, 14807000,
iast (18.253 s) : 18253000, 18253000
. : milestone, 18253000,
iast_GLOBAL (17.723 s) : 17723000, 17723000
. : milestone, 17723000,
profiling (14.858 s) : 14858000, 14858000
. : milestone, 14858000,
tracing (15.036 s) : 15036000, 15036000
. : milestone, 15036000,
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
|
/merge |
|
View all feedbacks in Devflow UI.
PR already in the queue with status in_progress |
What Does This Do
TagMap.put(...)calls withTagMap.set(...)insideCoreTracer.withTracerTags(...).TagMapmutation API in tracer tag merging logic.Motivation
TagMap.putusage inCoreTracer#withTraceTags(implemented inCoreTracer.withTracerTags).TagMap.putis deprecated in favor ofTagMap.set, so switching tosetavoids deprecated-path usage and aligns with currentTagMapAPI guidance.Additional Notes
dd-trace-core/src/main/java/datadog/trace/core/CoreTracer.javaonly.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: APMLP-1263
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.PR by Bits - View session in Datadog
Comment @DataDog to request changes