-
Notifications
You must be signed in to change notification settings - Fork 333
Add JDK built-in support for UDS on Java 16+ #8314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 21 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
ec126c8
Use the JDK's built-in support for Unix Domain Sockets on Java 16+
mcculls 87425f1
First draft of timeout test.
sarahchen6 1634bcd
Add server to test.
sarahchen6 683e7c1
Fix build.gradle file.
sarahchen6 662602a
Add debugging statements.
sarahchen6 64da205
Second draft of timeout test.
sarahchen6 953f3e8
Update getInputStream to use a selector.
sarahchen6 d07fc19
Clean code.
sarahchen6 2aec0e7
Adjust dd-java-agent build.gradle.
sarahchen6 ea9a237
Revert dd-java-agent build.gradle change
mcculls e475abd
Revert another build.gradle change.
sarahchen6 38b98db
Try specifying setSrcDirs.
sarahchen6 5ae79f9
Try changing compatibility version.
sarahchen6 e80ce7e
Revert previous two changes.
sarahchen6 6c188d9
Avoid implementation dependency for Java17.
sarahchen6 dda0997
Make gradle dependency more specific and add testImplementation to so…
sarahchen6 412e4d3
Add synchronization to ensure that server starts before client connects.
sarahchen6 381f841
Try this...
sarahchen6 beba316
Add print statements.
sarahchen6 305d9af
Add catch statement.
sarahchen6 8ff0eab
Refactor getInputStream and getOutputStream.
sarahchen6 0251e37
Address PR comments.
sarahchen6 114d230
Add test for when timeout is 0.
sarahchen6 37ca729
Add config option.
sarahchen6 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,31 @@ | ||
| ext { | ||
| minJavaVersionForTests = JavaVersion.VERSION_17 | ||
| } | ||
|
|
||
| apply from: "$rootDir/gradle/java.gradle" | ||
| apply plugin: "idea" | ||
|
|
||
| [compileMain_java17Java, compileTestJava].each { | ||
| it.configure { | ||
| setJavaVersion(it, 17) | ||
| sourceCompatibility = JavaVersion.VERSION_1_8 | ||
| targetCompatibility = JavaVersion.VERSION_1_8 | ||
| } | ||
| } | ||
|
|
||
| dependencies { | ||
| implementation libs.slf4j | ||
| implementation project(':internal-api') | ||
| implementation libs.jnr.unixsocket | ||
| testImplementation files(sourceSets.main_java17.output) | ||
| } | ||
|
|
||
| forbiddenApisMain_java17 { | ||
| failOnMissingClasses = false | ||
| } | ||
|
|
||
| implementation group: 'com.github.jnr', name: 'jnr-unixsocket', version: libs.versions.jnr.unixsocket.get() | ||
| idea { | ||
| module { | ||
| jdkName = '17' | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
252 changes: 252 additions & 0 deletions
252
utils/socket-utils/src/main/java17/datadog/common/socket/TunnelingJdkSocket.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,252 @@ | ||
| package datadog.common.socket; | ||
|
|
||
| import java.io.IOException; | ||
| import java.io.InputStream; | ||
| import java.io.OutputStream; | ||
| import java.net.InetAddress; | ||
| import java.net.InetSocketAddress; | ||
| import java.net.Socket; | ||
| import java.net.SocketAddress; | ||
| import java.net.SocketException; | ||
| import java.net.UnixDomainSocketAddress; | ||
| import java.nio.ByteBuffer; | ||
| import java.nio.channels.SelectionKey; | ||
| import java.nio.channels.Selector; | ||
| import java.nio.channels.SocketChannel; | ||
| import java.nio.file.Path; | ||
| import java.util.Iterator; | ||
| import java.util.Set; | ||
|
|
||
| /** | ||
| * Subtype UNIX socket for a higher-fidelity impersonation of TCP sockets. This is named "tunneling" | ||
| * because it assumes the ultimate destination has a hostname and port. | ||
| * | ||
| * <p>Bsed on {@link TunnelingUnixSocket}; adapted to use the built-in UDS support added in Java 16. | ||
| */ | ||
| final class TunnelingJdkSocket extends Socket { | ||
| private final SocketAddress unixSocketAddress; | ||
| private InetSocketAddress inetSocketAddress; | ||
|
|
||
| private SocketChannel unixSocketChannel; | ||
|
|
||
| private int timeout; | ||
| private boolean shutIn; | ||
| private boolean shutOut; | ||
| private boolean closed; | ||
|
|
||
| TunnelingJdkSocket(final Path path) { | ||
| this.unixSocketAddress = UnixDomainSocketAddress.of(path); | ||
| } | ||
|
sarahchen6 marked this conversation as resolved.
|
||
|
|
||
| TunnelingJdkSocket(final Path path, final InetSocketAddress address) { | ||
| this(path); | ||
| inetSocketAddress = address; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean isConnected() { | ||
| return null != unixSocketChannel; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean isInputShutdown() { | ||
| return shutIn; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean isOutputShutdown() { | ||
| return shutOut; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean isClosed() { | ||
| return closed; | ||
| } | ||
|
|
||
| @Override | ||
| public synchronized void setSoTimeout(int timeout) throws SocketException { | ||
| if (isClosed()) { | ||
| throw new SocketException("Socket is closed"); | ||
| } | ||
| if (timeout < 0) { | ||
| throw new IllegalArgumentException("Socket timeout can't be negative"); | ||
| } | ||
| this.timeout = timeout; | ||
| } | ||
|
|
||
| @Override | ||
| public synchronized int getSoTimeout() throws SocketException { | ||
| if (isClosed()) { | ||
| throw new SocketException("Socket is closed"); | ||
| } | ||
| return timeout; | ||
| } | ||
|
|
||
| @Override | ||
| public void connect(final SocketAddress endpoint) throws IOException { | ||
| if (isClosed()) { | ||
| throw new SocketException("Socket is closed"); | ||
| } | ||
| if (isConnected()) { | ||
| throw new SocketException("Socket is already connected"); | ||
| } | ||
| inetSocketAddress = (InetSocketAddress) endpoint; | ||
| unixSocketChannel = SocketChannel.open(unixSocketAddress); | ||
| } | ||
|
|
||
| @Override | ||
| public void connect(final SocketAddress endpoint, final int timeout) throws IOException { | ||
|
sarahchen6 marked this conversation as resolved.
|
||
| if (isClosed()) { | ||
| throw new SocketException("Socket is closed"); | ||
| } | ||
| if (isConnected()) { | ||
| throw new SocketException("Socket is already connected"); | ||
| } | ||
| inetSocketAddress = (InetSocketAddress) endpoint; | ||
| unixSocketChannel = SocketChannel.open(unixSocketAddress); | ||
| } | ||
|
|
||
| @Override | ||
| public SocketChannel getChannel() { | ||
| return unixSocketChannel; | ||
| } | ||
|
|
||
| @Override | ||
| public InputStream getInputStream() throws IOException { | ||
| if (isClosed()) { | ||
| throw new SocketException("Socket is closed"); | ||
| } | ||
| if (!isConnected()) { | ||
| throw new SocketException("Socket is not connected"); | ||
| } | ||
| if (isInputShutdown()) { | ||
| throw new SocketException("Socket input is shutdown"); | ||
| } | ||
|
|
||
| return new InputStream() { | ||
| private final ByteBuffer buffer = ByteBuffer.allocate(256); | ||
|
sarahchen6 marked this conversation as resolved.
Outdated
|
||
| private final Selector selector = Selector.open(); | ||
|
|
||
| { | ||
| unixSocketChannel.configureBlocking(false); | ||
| unixSocketChannel.register(selector, SelectionKey.OP_READ); | ||
| } | ||
|
|
||
| @Override | ||
| public int read() throws IOException { | ||
| byte[] nextByte = new byte[1]; | ||
| return (read(nextByte, 0, 1) == -1) ? -1 : (nextByte[0] & 0xFF); | ||
| } | ||
|
|
||
| @Override | ||
| public int read(byte[] b, int off, int len) throws IOException { | ||
| buffer.clear(); | ||
|
|
||
| int readyChannels = selector.select(timeout); | ||
|
sarahchen6 marked this conversation as resolved.
|
||
| if (readyChannels == 0) { | ||
| System.out.println("Timeout (" + timeout + "ms) while waiting for data."); | ||
| return 0; | ||
| } | ||
|
|
||
| Set<SelectionKey> selectedKeys = selector.selectedKeys(); | ||
| Iterator<SelectionKey> keyIterator = selectedKeys.iterator(); | ||
| while (keyIterator.hasNext()) { | ||
| SelectionKey key = keyIterator.next(); | ||
| keyIterator.remove(); | ||
| if (key.isReadable()) { | ||
| int r = unixSocketChannel.read(buffer); | ||
| if (r == -1) { | ||
| return -1; | ||
| } | ||
| buffer.flip(); | ||
| len = Math.min(r, len); | ||
| buffer.get(b, off, len); | ||
| return len; | ||
| } | ||
| } | ||
| return 0; | ||
| } | ||
|
|
||
| @Override | ||
| public void close() throws IOException { | ||
| selector.close(); | ||
| } | ||
| }; | ||
| } | ||
|
|
||
| @Override | ||
| public OutputStream getOutputStream() throws IOException { | ||
| if (isClosed()) { | ||
| throw new SocketException("Socket is closed"); | ||
| } | ||
| if (!isConnected()) { | ||
| throw new SocketException("Socket is not connected"); | ||
| } | ||
| if (isInputShutdown()) { | ||
| throw new SocketException("Socket output is shutdown"); | ||
| } | ||
|
|
||
| return new OutputStream() { | ||
| @Override | ||
| public void write(int b) throws IOException { | ||
| byte[] array = ByteBuffer.allocate(4).putInt(b).array(); | ||
| write(array, 0, 4); | ||
| } | ||
|
|
||
| @Override | ||
| public void write(byte[] b, int off, int len) throws IOException { | ||
| ByteBuffer buffer = ByteBuffer.wrap(b, off, len); | ||
|
|
||
| while (buffer.hasRemaining()) { | ||
| unixSocketChannel.write(buffer); | ||
| } | ||
| } | ||
| }; | ||
| } | ||
|
|
||
| @Override | ||
| public void shutdownInput() throws IOException { | ||
| if (isClosed()) { | ||
| throw new SocketException("Socket is closed"); | ||
| } | ||
| if (!isConnected()) { | ||
| throw new SocketException("Socket is not connected"); | ||
| } | ||
| if (isInputShutdown()) { | ||
| throw new SocketException("Socket input is already shutdown"); | ||
| } | ||
| unixSocketChannel.shutdownInput(); | ||
| shutIn = true; | ||
| } | ||
|
|
||
| @Override | ||
| public void shutdownOutput() throws IOException { | ||
| if (isClosed()) { | ||
| throw new SocketException("Socket is closed"); | ||
| } | ||
| if (!isConnected()) { | ||
| throw new SocketException("Socket is not connected"); | ||
| } | ||
| if (isOutputShutdown()) { | ||
| throw new SocketException("Socket output is already shutdown"); | ||
| } | ||
| unixSocketChannel.shutdownOutput(); | ||
| shutOut = true; | ||
| } | ||
|
|
||
| @Override | ||
| public InetAddress getInetAddress() { | ||
| return inetSocketAddress.getAddress(); | ||
| } | ||
|
|
||
| @Override | ||
| public void close() throws IOException { | ||
| if (isClosed()) { | ||
| return; | ||
| } | ||
| if (null != unixSocketChannel) { | ||
| unixSocketChannel.close(); | ||
| } | ||
| closed = true; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.