add test for network.client.ip tag

[smola]

Motivation

To align network.client.ip behavior, adding a system test. Most tracers already implemented collection of network.client.ip correctly. There was some ambiguity as to when to collect it. With most tracers collecting it only for AppSec events.

The spec is now amended to ensure that network.client.ip is collected for all HTTP request when the activation conditions are met. These are the same as for http.client_ip: when DD_APPSEC_ENABLED=true or DD_TRACE_CLIENT_IP_ENABLED=true are set.

APPSEC-62223

Changes

Workflow

1. ⚠️ Create your PR as draft ⚠️
2. Work on you PR until the CI passes
3. Mark it as ready for review
   • Test logic is modified? -> Get a review from RFC owner.
   • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

• Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
• A docker base image is modified?
  • the relevant build-XXX-image label is present
• A scenario is added, removed or renamed?
  • Get a review from R&P team

[github-actions]

CODEOWNERS have been resolved as:

manifests/java.yml                                                      @DataDog/asm-java @DataDog/apm-java
manifests/nodejs.yml                                                    @DataDog/dd-trace-js
manifests/php.yml                                                       @DataDog/apm-php @DataDog/asm-php
manifests/python.yml                                                    @DataDog/apm-python @DataDog/asm-python
manifests/ruby.yml                                                      @DataDog/ruby-guild @DataDog/asm-ruby
tests/test_standard_tags.py                                             @DataDog/system-tests-core

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c64707fae2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[chatgpt-codex-connector]

Gate network client IP tests by supported tracer versions

Adding this class enables it by default in DEFAULT and GO_PROXIES_DEFAULT for any library/version that lacks an explicit manifest rule, because unspecified tests are treated as enabled (see docs/edit/manifest.md). That creates a regression for older tracer versions that still do not emit http.client_ip/network.client.ip (the existing Test_StandardTagsClientIp is version-gated per language, e.g. in manifests/nodejs.yml and manifests/java.yml), so test_network_client_ip_with_attack can start failing in release-version runs. Please add class/method manifest gating for this new class with the same support floor as client-ip tagging.

Useful? React with 👍 / 👎.

[nccatoni]

LGTM for @DataDog/system-tests-core but you should get an approval from someone familiar with the feature