DataGrid: Fix focus getting stuck on Save button when columnRenderingMode is virtual (T1326106)#33201
Merged
Alyar666 merged 7 commits intoDevExpress:26_1from Apr 9, 2026
Merged
Conversation
added 2 commits
April 8, 2026 17:33
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes DataGrid Tab/Shift+Tab navigation in row editing mode when scrolling.columnRenderingMode = 'virtual', preventing focus from getting stuck on the Save button by skipping virtual-column scrolling when the browser should cycle through interactive elements within the current cell.
Changes:
- Adjusted Tab key handling to conditionally perform virtual-column horizontal scrolling only when appropriate for cell-to-cell navigation.
- Refactored virtual horizontal scrolling logic into smaller helper methods for readability.
- Added TestCafe E2E coverage for Tab/Shift+Tab focus transitions between Save/Cancel buttons in virtual column mode.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/grids/grid_core/keyboard_navigation/m_keyboard_navigation.ts | Skips virtual-column scroll when Tab should move within a cell’s interactive elements; refactors scroll decision logic. |
| e2e/testcafe-devextreme/tests/dataGrid/common/keyboardNavigation/virtualColumns.functional.ts | Adds regression tests validating Save/Cancel focus progression with Tab and Shift+Tab in row edit mode under virtual columns. |
packages/devextreme/js/__internal/grids/grid_core/keyboard_navigation/m_keyboard_navigation.ts
Outdated
Show resolved
Hide resolved
Raushen
reviewed
Apr 8, 2026
packages/devextreme/js/__internal/grids/grid_core/keyboard_navigation/m_keyboard_navigation.ts
Outdated
Show resolved
Hide resolved
added 2 commits
April 9, 2026 01:52
Raushen
reviewed
Apr 9, 2026
packages/devextreme/js/__internal/grids/grid_core/keyboard_navigation/utils.ts
Show resolved
Hide resolved
…Typing of util methods
Raushen
previously approved these changes
Apr 9, 2026
e2e/testcafe-devextreme/tests/dataGrid/common/keyboardNavigation/virtualColumns.functional.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/grids/grid_core/keyboard_navigation/utils.ts
Show resolved
Hide resolved
Raushen
approved these changes
Apr 9, 2026
Alyar666
added a commit
to Alyar666/DevExtreme
that referenced
this pull request
Apr 9, 2026
…Mode is virtual (T1326106) (DevExpress#33201) Co-authored-by: Alyar <>
Alyar666
added a commit
to Alyar666/DevExtreme
that referenced
this pull request
Apr 9, 2026
…Mode is virtual (T1326106) (DevExpress#33201) Co-authored-by: Alyar <>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.