Skip to content

add support for ne30pg2, WCAtl12to45E2r4 configuration#4177

Merged
jonbob merged 9 commits intomasterfrom
stephenprice/scripts/add-ne30pg2_WCAtl12to45E2r4
Apr 2, 2021
Merged

add support for ne30pg2, WCAtl12to45E2r4 configuration#4177
jonbob merged 9 commits intomasterfrom
stephenprice/scripts/add-ne30pg2_WCAtl12to45E2r4

Conversation

@stephenprice
Copy link
Copy Markdown
Contributor

@stephenprice stephenprice commented Mar 25, 2021 •
edited
Loading

Adds grid, domain, mapping file, data forcing (JRA, CORE), ocean restoring file, and ocean/ice namelist default support for new ne30pg2 (atmos) and WCAtl12to45E2r4 (ocean/ice) configuration.

[BFB]

@stephenprice stephenprice requested a review from vanroekel March 25, 2021 20:40
@darincomeau
Copy link
Copy Markdown
Member

darincomeau commented Mar 25, 2021

Link to the mesh generation PR: MPAS-Dev/compass#60
image

@vanroekel
Copy link
Copy Markdown
Contributor

vanroekel commented Mar 26, 2021

@jonbob I wasn't sure how to request this since it wasn't changed, but can we change the following

<config_eddying_resolution_ramp_min>20e3</config_eddying_resolution_ramp_min>
<config_eddying_resolution_ramp_max>30e3</config_eddying_resolution_ramp_max>

To be 30e3 and 40e3 respectively, just for this new grid?

Otherwise everything else looked good, but I would like to try this branch to launch a case with this mesh prior to approving

vanroekel
vanroekel approved these changes Mar 26, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@vanroekel vanroekel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by visual inspection and testing of case setup / build on chrysalis. Thanks @darincomeau, @stephenprice and @jonbob!

@darincomeau
Copy link
Copy Markdown
Member

darincomeau commented Mar 30, 2021

Approved based on successful 5 day smoke tests of the following compsets.resolutions on Anvil/Chrysalis:

WCYCL1850.ne30pg2_WCAtl12to45E2r4
GMPAS-IAF.T62_WCAtl12to45E2r4
GMPAS-JRA1p4.TL319_WCAtl12to45E2r4

jonbob
jonbob approved these changes Apr 1, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@jonbob jonbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from a visual inspection

@jonbob jonbob added the BFB PR leaves answers BFB label Apr 1, 2021
jonbob added a commit that referenced this pull request Apr 1, 2021
@jonbob
Merge branch 'stephenprice/scripts/add-ne30pg2_WCAtl12to45E2r4' into …
d06f296 
…next (PR #4177)

Add support for ne30pg2, WCAtl12to45E2r4 configuration

Adds grid, domain, mapping file, data forcing (JRA, CORE), ocean
restoring file, and ocean/ice namelist default support for new ne30pg2
(atmos) and WCAtl12to45E2r4 (ocean/ice) configuration.

[BFB]
@jonbob
Copy link
Copy Markdown
Contributor

jonbob commented Apr 1, 2021

merged to next

@jonbob jonbob merged commit 84678b1 into master Apr 2, 2021
@jonbob
Copy link
Copy Markdown
Contributor

jonbob commented Apr 2, 2021

merged to master

@jonbob jonbob deleted the stephenprice/scripts/add-ne30pg2_WCAtl12to45E2r4 branch April 2, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darincomeau darincomeau darincomeau approved these changes

@vanroekel vanroekel vanroekel approved these changes

@jonbob jonbob jonbob approved these changes

Assignees

@jonbob jonbob

Labels

BFB PR leaves answers BFB Coupled Model Scripts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stephenprice @darincomeau @vanroekel @jonbob