bugfix: sponsor packages page now has the same width as other pages#1529
Open
anorthall wants to merge 1 commit intoEuroPython:ep2026from
Open
bugfix: sponsor packages page now has the same width as other pages#1529anorthall wants to merge 1 commit intoEuroPython:ep2026from
anorthall wants to merge 1 commit intoEuroPython:ep2026from
Conversation
Previously, the sponsor packages page (`/sponsorship/sponsor/`) was not the same width as all other content pages (it was narrower and looked odd when navigating between pages). This was due to `MarkdownLayout` having different default styling than `SectionLayout`, the latter of which is used for most pages. I have fixed it by adding a `full` parameter to the frontmatter which is then handled in `MarkdownLayout` via `[...slug].astro` to allow pages to be full width. The `sponsor.mdx` page was updated with `full: true`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the sponsor packages page (
/sponsorship/sponsor/) was not the same width as all other content pages (it was narrower and looked odd when navigating between pages).This was due to
MarkdownLayouthaving different default styling thanSectionLayout, the latter of which is used for most pages.I have fixed it by adding a
fullparameter to the frontmatter which is then handled inMarkdownLayoutvia[...slug].astroto allow pages to be full width. Thesponsor.mdxpage was updated withfull: true.Screenshots
Before
After
Mobile
Designed / layout is unchanged on mobile.
🖼️ Preview available 🖼️ : https://ep-website--1529.org.readthedocs.build/