feat(schema): update Tag and Category enums#112
Conversation
- Reorganize Tag enum into logical groups (People & Teams, Projects & Protocols, Organizations, Cryptoassets, Exchanges & Marketplaces, Events, Ecosystem Tags) and update Category enum to match the new classification structure.
🦋 Changeset detectedLatest commit: 4aa3a97 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refines the classification system for entities within the application by restructuring the Tag and Category enums. The changes aim to provide a more granular, logical, and consistent way to categorize various blockchain-related concepts, improving data organization and future extensibility. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.gh.lumenfield.work/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the Tag and Category enums for better organization and consistency. The changes are generally good, introducing logical grouping for tags and standardized naming for categories. However, I've identified a couple of potential issues. There's a significant inconsistency between the updated Tag enum and the existing LinkedWikiKey enum, which could lead to bugs. Additionally, the Polygon tag, which was previously present, seems to be missing from the new list of ecosystem tags, which might be an oversight.
src/schema/index.ts
Outdated
There was a problem hiding this comment.
Government should be moved to // Organizations section, so that existing tags will be easier to remove later
src/schema/index.ts
Outdated
| @@ -117,18 +118,72 @@ export const Tag = z.enum([ | |||
| "Speakers", | |||
| "Stablecoins", | |||
| "Venture", | |||
There was a problem hiding this comment.
Venture should be moved to // Organizations section, so that existing tags will be easier to remove later
src/schema/index.ts
Outdated
There was a problem hiding this comment.
Conference should be moved to // Events section
src/schema/index.ts
Outdated
There was a problem hiding this comment.
Hackathon should be moved to // Events section
src/schema/index.ts
Outdated
There was a problem hiding this comment.
Ethereum should be moved to // Universal section
src/schema/index.ts
Outdated
| @@ -117,18 +118,72 @@ export const Tag = z.enum([ | |||
There was a problem hiding this comment.
Solana should be moved to // Universal section
src/schema/index.ts
Outdated
There was a problem hiding this comment.
Polkadot should be moved to // Universal section
src/schema/index.ts
Outdated
| export type EventType = z.infer<typeof EventType>; | ||
|
|
||
| export const Tag = z.enum([ | ||
| // Existing Tags |
There was a problem hiding this comment.
We can rename this to // Other Tags since some of the existing tags will now be in the new sections
2 participants
Closes https://github.com/EveripediaNetwork/issues/issues/4796 when this PR merged
Summary
Tagenum into logical groups: People & Teams, Projects & Protocols, Organizations, Cryptoassets, Exchanges & Marketplaces, Events, and Universal Ecosystem TagsCategoryenum to match the new classification structure with snake_case naming (people_and_teams,projects_and_protocols,organizations,cryptoassets,exchanges_and_marketplaces,events)Test plan
isEventWikiValidstill works (theEventstag is preserved)