Prohibit inheritance of interface with versioned methods#8982
Merged
dyemanov merged 3 commits intoFirebirdSQL:masterfrom Apr 9, 2026
Merged
Prohibit inheritance of interface with versioned methods#8982dyemanov merged 3 commits intoFirebirdSQL:masterfrom
dyemanov merged 3 commits intoFirebirdSQL:masterfrom
Conversation
dyemanov
reviewed
Apr 7, 2026
dyemanov
reviewed
Apr 7, 2026
dyemanov
reviewed
Apr 7, 2026
Contributor
|
Because public API has C++11 enabled, |
dyemanov
approved these changes
Apr 7, 2026
AlexPeshkoff
approved these changes
Apr 7, 2026
Member
AlexPeshkoff
left a comment
AlexPeshkoff
left a comment
There was a problem hiding this comment.
I think this patch is enough for our needs on practice. This is the first time for >10 years when need to add method to base interface took place, therefore nothing except added check is really needed.
asfernandes
approved these changes
Apr 7, 2026
Member
asfernandes
left a comment
asfernandes
left a comment
There was a problem hiding this comment.
Is the PR title correct or should it be 'inheritance'?
Noremos
changed the title
Contributor
Author
My bad. Now the title is correct |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for: #8980