Open
Conversation
Now using setuptools instead of distutils
Remove the Python directory build steps from the Makefile, relying on "make install" to set them up properly. Modify the manual to mention that setting the PYTHONPATH is not necessary after running make install.
for more information, see https://pre-commit.ci
Patol75
reviewed
Mar 30, 2026
Contributor
There was a problem hiding this comment.
These changes look reasonable to me. I see a few CI failures, but they are likely not related to this PR. Are the spherical benchmark longtest failures linked to changes in assess? particle_rayleigh_taylor_checkpoint seems to fail intermittently, so nothing too concerning there.
EDIT: Yes, spherical failures are due to assess (https://github.com/FluidityProject/fluidity/actions/runs/23657117725).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now using setuptools instead of distutils. The CI does not build python so testing must be done manually by running the configure as