Merged
Conversation
Closed
# Conflicts: # backend/src/main/java/ai/giskard/config/SecurityConfiguration.java
# Conflicts: # backend/src/main/java/ai/giskard/config/SecurityConfiguration.java
Inokinoki
reviewed
Aug 30, 2023
| wait=False, | ||
| headers={ | ||
| "jwt": self.client.session.auth.token, | ||
| "api-key": self.client.session.auth.token, |
Member
There was a problem hiding this comment.
Will we change auth for internal worker later or also here?
Contributor
Author
There was a problem hiding this comment.
yes, internal worker will use persistent API key too
Contributor
Author
There was a problem hiding this comment.
I think we should generate a "system" api key upon first Giskard boot or take it from env variable and use it by internal worker. The benefits compared to current jwt mechanism:
- system api key will remain the same between restarts
- depending on how we generate it it can be known by backend and ml worker at boot time (in case it's set in the env variable). This makes the auth mechanism easier as there's no need to wait for backend to boot to generate a jwt token
Member
There was a problem hiding this comment.
No problem, it will be an internal change.
I created GSK-1663 and we can do it later, apart from this PR.
Member
|
LGTM, the tests also passed. I'll update #1277 after merge accordingly, if any |
# Conflicts: # backend/src/main/java/ai/giskard/config/SecurityConfiguration.java
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Save API keys in DB so that they don't expire