Fixed issue of RAG results plots rendering#2036
Merged
kevinmessiaen merged 1 commit intomainfrom Sep 30, 2024
Merged
Conversation
Bokeh >= 3.6 cause issue with rendering plots when saving to html file
|
henchaves
approved these changes
Sep 27, 2024
Member
henchaves
left a comment
There was a problem hiding this comment.
I tested with bokeh==3.6.0 and bokeh==3.4.3. Indeed, the plot generated using the version 3.6.0 was broken.
LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Bokeh >= 3.6 cause issue with rendering plots when saving to html file
How to reproduce
Run this code
Open the
test.htmlgenerated file to see that the plot is not rendering whenbokeh>3.6Type of Change