Conversation
googlebot
added
the
cla: yes
|
Hi @telpirion, some of the vision tests are failing on this PR. Let me know when you hace check those and I can review. |
| private static object DetectTextWithLocation(Image image) | ||
| { | ||
| // [START vision_set_endpoint] | ||
|
|
There was a problem hiding this comment.
Extraneous newline. I looked at the other samples and this isn't present in the other samples.
| Endpoint = new ServiceEndpoint("eu-vision.googleapis.com") | ||
| }.Build(); | ||
| // [END vision_set_endpoint] | ||
|
|
There was a problem hiding this comment.
Extraneous newline. Besides these 2 extra lines (I looked at the other samples in this file and they don't have empty newlines), all LGTM
amanda-tarafa
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
amanda-tarafa
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
Hi @telpirion, I fixed the lint issue on Storage but the Vision tests are still failing on this PR (apparently there's a file missing somewhere).
|
amanda-tarafa
left a comment
amanda-tarafa
left a comment
There was a problem hiding this comment.
LGTM with a very minor nit.
| { | ||
| // [START vision_set_endpoint] | ||
| // Instantiate a client connected to the 'eu' location. | ||
| var client = new ImageAnnotatorClientBuilder() |
There was a problem hiding this comment.
nit: Remove the (), they are not needed on object initializers.
There was a problem hiding this comment.
Did not know that! Thank you.
amanda-tarafa
left a comment
amanda-tarafa
left a comment
There was a problem hiding this comment.
LGTM! Happy for you to merge.
5 participants
This pull request adds the following region_tag:
vision_set_endpoint
The canonical sample is here:
GoogleCloudPlatform/python-docs-samples#2569