Skip to content

node: add upstream patch to fix webpack build#197917

Merged
BrewTestBot merged 2 commits intomasterfrom
node-patch
Nov 17, 2024
Merged

node: add upstream patch to fix webpack build#197917
BrewTestBot merged 2 commits intomasterfrom
node-patch

Conversation

@chenrui333
Copy link
Copy Markdown
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

currently node 23 is causing some webpack build issue, and adding the upstream revert PR to would help address it.

relates to:

Signed-off-by: Rui Chen <rui@chenrui.dev>
@github-actions github-actions Bot added long build Set a long timeout for formula testing icu4c ICU use is a significant feature of the PR or issue long dependent tests Set a long timeout for dependent testing labels Nov 16, 2024
@Homebrew Homebrew deleted a comment from github-actions Bot Nov 16, 2024
@chenrui333 chenrui333 added ready to merge PR can be merged once CI is green CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. labels Nov 16, 2024
Copy link
Copy Markdown
Member

@branchv branchv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sapling will be fixed with #197728

@github-actions
Copy link
Copy Markdown
Contributor

:shipit: @branchvincent has requested bottles to be published to this PR.

@github-actions github-actions Bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 17, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 17, 2024
Merged via the queue into master with commit d809a22 Nov 17, 2024
@BrewTestBot BrewTestBot deleted the node-patch branch November 17, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. icu4c ICU use is a significant feature of the PR or issue long build Set a long timeout for formula testing long dependent tests Set a long timeout for dependent testing ready to merge PR can be merged once CI is green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants