install: explicitly set shellenv suffix if possible.#1067
Merged
MikeMcQuaid merged 1 commit intomainfrom Jan 8, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request modifies the Homebrew installation script to explicitly set shell-specific suffixes for the brew shellenv command, avoiding error-prone autodetection. The change ensures that users are instructed to run the correct variant of brew shellenv based on their detected shell.
Key changes:
- Added
shellenv_suffixvariable assignments for bash, zsh, fish, and default shells - Updated grep pattern to match any shellenv variant
- Modified command instructions to include the appropriate shell-specific suffix
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This will avoid more error-prone autodetection in `brew shellenv`. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
MikeMcQuaid
force-pushed
the
shellenv_suffix
branch
from
fb4c415 to
75916be
Compare
p-linnane
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will avoid more error-prone autodetection in
brew shellenv.Related to Homebrew/brew#21374