Revert "Revert "Filter upgrades to support kw params""#534
Merged
Conversation
Collaborator
|
To follow up, I think we should be using the TruthyTypeConverter instead of straight up casting of objects to mimic Python behavior. |
Contributor
|
Hi @boulter @mattcoley is there a jinja template with expected output that could help verify this? |
Contributor
|
Please take a look at my branch that uses TruthyTypeConverter. |
Contributor
Author
|
@michaelpro1 I merged in your changes. |
boulter
deleted the
revert-533-revert-531-feature/abstractfilter-upgrades-1
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #533
@michaelpro1 can you take a look?