Widen error responses that trigger re-authentication#30
Merged
Conversation
Apart from token expiry, we have encountered at least two other kinds of persistent error responses that are resolved by re-authentication (presumably other kinds of token invalidation). The client is effectively broken once this happens until a re-auth is done. This change widens the "requires re-auth" criteria used to catch those and potentially others. It also includes some related hardening/refactoring of how automatic re-auths are handled. The original RPC that triggered the auth failure is now included in the cause chain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apart from token expiry, we have encountered at least two other kinds of persistent error responses that are resolved by re-authentication (presumably other kinds of token invalidation). The client is
effectively broken once this happens until a re-auth is done.
This change widens the "requires re-auth" criteria used to catch those and potentially others.
It also includes some related hardening/refactoring of how automatic re-auths are handled. The original RPC that triggered the auth failure is now included in the cause chain.