Conversation
slarse
approved these changes
Oct 6, 2022
Collaborator
slarse
left a comment
There was a problem hiding this comment.
LGTM, should we go ahead and make the release?
Collaborator
Author
|
I also +1
|
MartinWitt
approved these changes
Oct 8, 2022
Collaborator
|
As I really dont know how we create releases feel free to merge it @monperrus if everything is ready. |
Collaborator
Author
|
Here is what I've done:
|
Collaborator
|
Should the description of this PR be updated? It currently does not contain the PRs that where merged after the PR was opened. |
Collaborator
Author
|
You're right @SirYwell, thanks. Fixed with 3 additional bug fixes. Next time, we'll try to minimize the time between opening and merging of the release PR! |
Collaborator
I agree, maybe we can even "freeze" the master branch during that time. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New features
Bug fixes
CtLiteralnodes. (PR: fix: attach comment toCtLiteralnodes #4836)Performance
Governance
Authors