File Metadata Update - Empty values clear fields#11439
Merged
ofahimIQSS merged 22 commits intodevelopfrom Jul 21, 2025
Merged
Conversation
github-actions
bot
added
FY25 Sprint 21
stevenwinship
added
Feature: API
Size: 20
![github-advanced-security[bot]](https://avatars.gh.lumenfield.work/in/57789?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
stevenwinship
added
Size: 10
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
pdurbin
reviewed
Jul 14, 2025
| ---- | ||
|
|
||
| - An undocumented :doc:`search` parameter called "show_my_data" has been removed. It was never exercised by tests and is believed to be unused. API users should use the :ref:`api-mydata` API instead. | ||
| - For POST /api/files/{id}/metadata passing an empty string (“description”:””) or array (“categories”:[]) will no longer be ignored. Empty fields will now clear out the values in the file's metadata. To ignore the fields simply do not include them in the Json string. |
Member
There was a problem hiding this comment.
Are we trying to get this in 6.7? If not, this should be placed under "v6.8" in the changelog.
sourceInternalVersionNumber is gone right? Should we mention that?
Also, I would suggest replacing the smart quotes with straight quotes and writing "JSON" in all caps.
|
|
||
| #AbstractApiBean.java | ||
| abstractApiBean.error.internalVersionTimestampIsOutdated=Internal version timestamp {0} is outdated | ||
| abstractApiBean.error.datasetInternalVersionNumberIsOutdated=Dataset internal version number {0} is outdated |
Member
There was a problem hiding this comment.
Can we remove this bundle entry? It seems to be unused now.
pdurbin
approved these changes
Jul 14, 2025
Member
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
The changes look good. Thanks. Now that we're mentioning 6.8 explicitly in the guides, I added the 6.8 milestone.
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
g-saracca
added
SPA.Q3.2025
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
Contributor
|
tests are passing - merging |
github-project-automation
bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
Member
|
As @JR-1991 and I have been discussing, this change in behavior resulted in test failures here: Thanks for putting something in the "breaking changes" API changelog. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: No way to clear the fields with the API since empty fields were being ignored
Which issue(s) this PR closes:#11392
Special notes for your reviewer:
Suggestions on how to test this: See FilesIT test
Does this PR introduce a user interface change? If mockups are available, please link/include them here: No
Is there a release notes update needed for this change?: Included
Additional documentation: Included