Fix picker toggle and picker actions - time-picker sample#3863
Merged
kacheshmarova merged 2 commits intovnextfrom Jan 13, 2026
Merged
Fix picker toggle and picker actions - time-picker sample#3863kacheshmarova merged 2 commits intovnextfrom
kacheshmarova merged 2 commits intovnextfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the time picker sample by correcting the picker toggle behavior and updating the picker actions directive to use the proper generic directive.
- Removes manual toggle handler from the icon, allowing
igx-picker-toggleto handle it automatically - Updates the picker actions directive from the component-specific
igxTimePickerActionsto the genericigxPickerActions - Adds the required
IgxPickerActionsDirectiveimport
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| timepicker-sample-6.component.ts | Adds IgxPickerActionsDirective to imports and component metadata to support the generic picker actions directive |
| timepicker-sample-6.component.html | Removes redundant manual toggle handler and updates template directive from igxTimePickerActions to igxPickerActions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ddaribo
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3803