Skip to content

feat(routing): configure after migration to standalone#59

Merged
ChronosSF merged 2 commits intomasterfrom
bpachilova/configure-routing-standalone
Oct 22, 2025
Merged

feat(routing): configure after migration to standalone#59
ChronosSF merged 2 commits intomasterfrom
bpachilova/configure-routing-standalone

Conversation

@ddaribo
Copy link
Copy Markdown
Contributor

@ddaribo ddaribo commented Oct 8, 2025

Closes 3623

Adds minimal configuration needed to add routes to samples after the migration to standalone components.

Related igniteui-angular-samples PR here

@kdinev kdinev requested a review from Copilot October 8, 2025 13:18
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds routing configuration support to standalone Angular components after migration from module-based architecture. It replaces the previous boolean router flag with a more comprehensive RoutesConfig interface that supports configurable routing paths.

  • Introduced RoutesConfig interface with router boolean and routesImportPath string properties
  • Updated template generation to conditionally import and use RouterOutlet based on routing configuration
  • Modified app config generation to import routes from specified path when routing is enabled

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/templates/app.component.ts.template Added conditional RouterOutlet import and component registration
src/public.ts Replaced boolean router flag with RoutesConfig interface
src/generators/SampleAssetsGenerator.ts Updated routing logic to use new RoutesConfig structure

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/generators/SampleAssetsGenerator.ts Outdated
Comment thread src/generators/SampleAssetsGenerator.ts Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/generators/SampleAssetsGenerator.ts
@ddaribo ddaribo force-pushed the bpachilova/configure-routing-standalone branch from e9713c8 to 0a2da67 Compare October 8, 2025 13:42
@ddaribo ddaribo requested a review from Copilot October 8, 2025 13:42
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ddaribo ddaribo requested a review from ChronosSF October 8, 2025 13:43
@ChronosSF ChronosSF requested a review from dobromirts October 20, 2025 11:42
@ChronosSF ChronosSF merged commit d426979 into master Oct 22, 2025
5 checks passed
@ChronosSF ChronosSF deleted the bpachilova/configure-routing-standalone branch October 22, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

All grids state persistence samples: routing configuration is missing for live-editing

4 participants