Acquire GIL around every Python API call#1097
Draft
topolarity wants to merge 3 commits intoJuliaPy:masterfrom
Draft
Acquire GIL around every Python API call#1097topolarity wants to merge 3 commits intoJuliaPy:masterfrom
topolarity wants to merge 3 commits intoJuliaPy:masterfrom
Conversation
topolarity
force-pushed
the
ct/with-gil
branch
5 times, most recently
from
b3aea39 to
dd3cc6d
Compare
Author
|
Before this can be considered complete, it needs an equivalent to JuliaMath/FFTW.jl#160 to handle:
edit: Done! |
Majority of the API is covered by updating the `@pycheck(v/n)` macros. The rest is covered manually by `@with_GIL`. Care should be taken to avoid yielding to the Julia scheduler, which could cause task migration and lead to deadlocks.
topolarity
force-pushed
the
ct/with-gil
branch
3 times, most recently
from
a395a25 to
25038c7
Compare
This is required to avoid deadlocking in the GC as it executes finalizers.
Required to avoid starving the scheduler or deadlocking against the GC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should resolve #1096 by wrapping every Python API usage in a GIL acquire-release.
If this leads to overhead, we can probably re-export a "manual GIL" version of the API that allows consumers to manage the GIL themselves. In any case, it's worth having proper support for multi-threading.
Fixes #1096. Fixes #1095. Fixes #1090. Fixes #1088.
Fixes #1078. Fixes #1077. Fixes #1072. Fixes #1083.
Fixes timholy/Revise.jl#989.