Conversation
38 tasks
Ayushk4
reviewed
Feb 6, 2020
Member
Ayushk4
left a comment
Ayushk4
left a comment
There was a problem hiding this comment.
One small typo. Otherwise LGTM. 👍
Co-Authored-By: Ayush Kaushal <ayushk4@gmail.com>
Ayushk4
approved these changes
Feb 6, 2020
Member
|
LGTM. Merging this. |
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
=======================================
Coverage 94.09% 94.09%
=======================================
Files 10 10
Lines 525 525
=======================================
Hits 494 494
Misses 31 31Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openjournals/joss-reviews#1956 (comment)
@Ayushk4 if you are happy with this merge it and comment on the JOSS issue