Conversation
leplatrem
force-pushed
the
add-python3.8-support
branch
from
1568e83 to
83042f7
Compare
Contributor
Author
|
I really don't understand the coverage failure with Py38. When I run the tests locally with py38 and add a breakpoint, I can see that the lines are all executed as expected. @Natim what should we do? Add a |
Member
|
I am pretty sure we are missing a test or the if is wrong in the test with py38. |
Contributor
Author
The line is executed in my local py38... |
Member
|
I am pretty sure this is something like bytes vs str variables. Could we log the password and confirm_password values that we have in travis? |
Member
|
Maybe memcached is needed for those tests. |
Member
|
I confirm 100% even with removing .coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.