Skip to content

sdk: align cascade evidence payload with no-map chain schema#280

Merged
mateeullahmalik merged 2 commits intomasterfrom
nightcrawler/no-maps-proto-evidence
Apr 15, 2026
Merged

sdk: align cascade evidence payload with no-map chain schema#280
mateeullahmalik merged 2 commits intomasterfrom
nightcrawler/no-maps-proto-evidence

Conversation

@mateeullahmalik
Copy link
Copy Markdown
Collaborator

@mateeullahmalik mateeullahmalik commented Mar 31, 2026

Summary

Align supernode SDK cascade-client-failure evidence payload with chain proto no-map migration.

Changes

  • Replaced map-based details payload with typed CascadeClientFailureDetails in SDK task pipeline
  • Updated lumera adapter mapping into chain metadata struct
  • Included storage-challenge evidence submission path as structured metadata flow via StorageChallengeFailureEvidenceMetadata (no map payload), plus dedicated helper/test coverage in storage challenge service
  • Updated go.mod/go.sum to consume lumera commit with proto changes

Why

Keep SDK and chain metadata contracts in sync after map removal, and enforce explicit field-level payload semantics across both cascade-client-failure and storage-challenge evidence paths.

Validation

  • go test ./sdk/...
  • go test ./supernode/storage_challenge -run TestBuildStorageChallengeFailureEvidenceMetadata_NoMapPayload

@roomote-v0
Copy link
Copy Markdown

roomote-v0 bot commented Mar 31, 2026

Rooviewer Clock   See task

No issues found. The extraction of the struct literal into buildStorageChallengeFailureEvidenceMetadata is a clean mechanical refactor with correct field mappings. The new test validates both field correctness and the no-map serialization contract via JSON round-trip.

Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

roomote-v0[bot]
roomote-v0 bot previously approved these changes Mar 31, 2026
@mateeullahmalik mateeullahmalik merged commit 8a285ba into master Apr 15, 2026
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant