Conversation
Expand platform support, update Go dependency, add Makefile target, and refine repo structure.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR advances the “Everlight” slice by teaching the supernode codebase about the new SUPERNODE_STATE_STORAGE_FULL state and by reporting the cascade_kademlia_db_bytes LEP-4 metric (derived from the P2P DB size), alongside dependency bumps and substantial BRIDGE methodology/documentation scaffolding.
Changes:
- Add
SUPERNODE_STATE_STORAGE_FULLto the Lumera adapter and allow STORAGE_FULL nodes to start with a warning distinct from POSTPONED. - Populate
SupernodeMetrics.CascadeKademliaDbBytesfrom P2P database metrics (MB → bytes) with nil-safe access. - Update module deps (CometBFT) and add extensive BRIDGE docs/config/agent scaffolding.
Reviewed changes
Copilot reviewed 92 out of 97 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/system/go.sum | Adds CometBFT 0.38.21 go.mod checksum (but lacks module checksum). |
| tests/system/go.mod | Bumps Go directive and CometBFT requirement for system tests module. |
| supernode/verifier/verifier.go | Allows STORAGE_FULL startup with warning; clarifies POSTPONED warning semantics. |
| supernode/verifier/verifier_test.go | Adds unit tests asserting STORAGE_FULL/POSTPONED behavior (warnings, validity). |
| supernode/supernode_metrics/metrics_collection.go | Reports CascadeKademliaDbBytes from P2P DB size metrics. |
| sn-manager/go.mod | Bumps Go directive; updates indirect CometBFT. |
| sdk/adapters/lumera/types.go | Adds STORAGE_FULL enum constant and parsing support. |
| sdk/adapters/lumera/types_test.go | Adds unit test for STORAGE_FULL parsing. |
| Makefile | Adds all-tests aggregate target. |
| go.sum | Updates CometBFT sums; removes lumera sums (consistent with local replace usage). |
| go.mod | Bumps Go directive; adds local replace for lumera; updates CometBFT requirement. |
| docs/requirements.json | Adds BRIDGE requirements doc for Everlight slice (includes toolchain constraint). |
| docs/plans/Cascade-Everlight-phase1-plan.md | Adds Phase 1 plan documentation. |
| docs/plans/Cascade-Everlight-Feature-Proposal.md | Adds detailed Everlight feature proposal doc. |
| docs/plans/Cascade-Everlight-Brief.md | Adds high-level Everlight brief doc. |
| docs/human-playbook.md | Adds placeholder human playbook file for BRIDGE generation. |
| docs/decisions.md | Adds ADR log scaffold. |
| docs/context.json | Adds BRIDGE context/state tracking for the slice. |
| cmd/sncli/go.sum | Adds CometBFT 0.38.21 go.mod checksum (but lacks module checksum). |
| cmd/sncli/go.mod | Bumps Go directive; updates indirect CometBFT. |
| CLAUDE.md | Adds BRIDGE v2.1 project rules/scaffolding. |
| AGENTS.md | Adds BRIDGE v2.1 agent methodology/scaffolding. |
| .gitignore | Stops ignoring CLAUDE.md/AGENTS.md; adjusts ignore entries. |
| .codex/config.toml | Adds Codex BRIDGE profile configuration. |
| .claude/specialists/testing-qa.md | Adds specialist guidance file. |
| .claude/specialists/security-auth.md | Adds specialist guidance file. |
| .claude/specialists/frontend-ui.md | Adds specialist guidance file. |
| .claude/specialists/devops-infra.md | Adds specialist guidance file. |
| .claude/specialists/database.md | Adds specialist guidance file. |
| .claude/specialists/catalog.md | Adds specialist catalog. |
| .claude/specialists/api-design.md | Adds specialist guidance file. |
| .claude/skills/bridge-slice-plan/SKILL.md | Adds BRIDGE skill definition. |
| .claude/skills/bridge-session-management/SKILL.md | Adds BRIDGE skill definition. |
| .claude/skills/bridge-gate-audit/SKILL.md | Adds BRIDGE skill definition. |
| .claude/skills/bridge-feedback-process/SKILL.md | Adds BRIDGE skill definition. |
| .claude/skills/bridge-eval-generate/SKILL.md | Adds BRIDGE skill definition. |
| .claude/skills/bridge-context-sync/SKILL.md | Adds BRIDGE skill definition. |
| .claude/settings.json | Adds Claude tool permissions and hook config. |
| .claude/rules/security.md | Adds security rules doc. |
| .claude/rules/methodology.md | Adds BRIDGE methodology rules doc. |
| .claude/hooks/session-start.sh | Adds BRIDGE session-start hook. |
| .claude/hooks/README.md | Documents hooks. |
| .claude/hooks/post-edit-lint.sh | Adds post-edit lint hook. |
| .claude/hooks/auto-approve-cd-git.sh | Adds auto-approve hook for safe git commands. |
| .claude/commands/bridge-start.md | Adds BRIDGE command. |
| .claude/commands/bridge-scope.md | Adds BRIDGE command. |
| .claude/commands/bridge-resume.md | Adds BRIDGE command. |
| .claude/commands/bridge-requirements.md | Adds BRIDGE command. |
| .claude/commands/bridge-requirements-only.md | Adds BRIDGE command. |
| .claude/commands/bridge-project-brief.md | Adds BRIDGE command. |
| .claude/commands/bridge-gate.md | Adds BRIDGE command. |
| .claude/commands/bridge-feedback.md | Adds BRIDGE command. |
| .claude/commands/bridge-feature.md | Adds BRIDGE command. |
| .claude/commands/bridge-eval.md | Adds BRIDGE command. |
| .claude/commands/bridge-end.md | Adds BRIDGE command. |
| .claude/commands/bridge-design.md | Adds BRIDGE command. |
| .claude/commands/bridge-context-update.md | Adds BRIDGE command. |
| .claude/commands/bridge-context-create.md | Adds BRIDGE command. |
| .claude/commands/bridge-brainstorm.md | Adds BRIDGE command. |
| .claude/commands/bridge-advisor.md | Adds BRIDGE command. |
| .claude/agents/bridge-evaluator.md | Adds evaluator agent config. |
| .claude/agents/bridge-debugger.md | Adds debugger agent config. |
| .claude/agents/bridge-coder.md | Adds coder agent config. |
| .claude/agents/bridge-auditor.md | Adds auditor agent config. |
| .claude/agents/bridge-architect.md | Adds architect agent config. |
| .bridgeinclude | Adds workspace/repo metadata for BRIDGE tooling. |
| .agents/specialists/testing-qa.md | Mirrors specialist guidance under .agents/. |
| .agents/specialists/security-auth.md | Mirrors specialist guidance under .agents/. |
| .agents/specialists/frontend-ui.md | Mirrors specialist guidance under .agents/. |
| .agents/specialists/devops-infra.md | Mirrors specialist guidance under .agents/. |
| .agents/specialists/database.md | Mirrors specialist guidance under .agents/. |
| .agents/specialists/catalog.md | Mirrors specialist catalog under .agents/. |
| .agents/specialists/api-design.md | Mirrors specialist guidance under .agents/. |
| .agents/skills/bridge-start/SKILL.md | Adds BRIDGE skill under .agents/. |
| .agents/skills/bridge-scope/SKILL.md | Adds BRIDGE skill under .agents/. |
| .agents/skills/bridge-resume/SKILL.md | Adds BRIDGE skill under .agents/. |
| .agents/skills/bridge-requirements/SKILL.md | Adds BRIDGE skill under .agents/. |
| .agents/skills/bridge-requirements-only/SKILL.md | Adds BRIDGE skill under .agents/. |
| .agents/skills/bridge-project-brief/SKILL.md | Adds BRIDGE skill under .agents/. |
| .agents/skills/bridge-gate/SKILL.md | Adds BRIDGE skill under .agents/. |
| .agents/skills/bridge-feedback/SKILL.md | Adds BRIDGE skill under .agents/. |
| .agents/skills/bridge-feature/SKILL.md | Adds BRIDGE skill under .agents/. |
| .agents/skills/bridge-eval/SKILL.md | Adds BRIDGE skill under .agents/. |
| .agents/skills/bridge-end/SKILL.md | Adds BRIDGE skill under .agents/. |
| .agents/skills/bridge-design/SKILL.md | Adds BRIDGE skill under .agents/. |
| .agents/skills/bridge-context-update/SKILL.md | Adds BRIDGE skill under .agents/. |
| .agents/skills/bridge-context-create/SKILL.md | Adds BRIDGE skill under .agents/. |
| .agents/skills/bridge-brainstorm/SKILL.md | Adds BRIDGE skill under .agents/. |
| .agents/skills/bridge-advisor/SKILL.md | Adds BRIDGE skill under .agents/. |
| .agents/procedures/bridge-slice-plan.md | Adds BRIDGE procedure under .agents/. |
| .agents/procedures/bridge-session-management.md | Adds BRIDGE procedure under .agents/. |
| .agents/procedures/bridge-gate-audit.md | Adds BRIDGE procedure under .agents/. |
| .agents/procedures/bridge-feedback-process.md | Adds BRIDGE procedure under .agents/. |
| .agents/procedures/bridge-eval-generate.md | Adds BRIDGE procedure under .agents/. |
| .agents/procedures/bridge-context-sync.md | Adds BRIDGE procedure under .agents/. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
5
to
7
| replace ( | ||
| github.com/LumeraProtocol/lumera => ../lumera | ||
| github.com/envoyproxy/protoc-gen-validate => github.com/bufbuild/protoc-gen-validate v1.3.0 |
There was a problem hiding this comment.
The replace github.com/LumeraProtocol/lumera => ../lumera directive will break builds in CI/clean checkouts where that relative path doesn’t exist. If this is only for local development, prefer a go.work workspace or keep the replace out of the main branch and pin to a tagged lumera release that contains the needed Everlight protos.
Comment on lines
123
to
+128
| .PHONY: test-e2e test-unit test-integration test-system test-cascade test-sn-manager | ||
| .PHONY: install-lumera setup-supernodes system-test-setup install-deps | ||
| .PHONY: gen-cascade gen-supernode | ||
|
|
||
| all-tests: test-e2e test-unit test-integration test-system test-cascade test-sn-manager | ||
|
|
There was a problem hiding this comment.
all-tests is a new Make target but isn’t listed in .PHONY. If a file named all-tests exists, make all-tests can become a no-op. Add all-tests to the existing .PHONY list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.