Conversation
- first stab: not touching Eclipse bundles yet (no Tycho yet) - removing jars that can now be obtained via Maven - removing Eclipse configuration files that are now automatically generated when imported as Maven projects - some tests were relying on both JUnit 4 and 5 - using JUnit 5 only now - renamed test source path for the test module
|
@seidewitz This is now ready for review. The only thing I didn't do yet is to generate the dist jars with their final names, I am ATM generating them using a "new-" prefix, so they do not overwrite yet the dist files you created by hand. Oh, the other thing I didn't enable was enabling CI on Travis (as I did in my fork under my own user name) and pushing the binaries to a Maven repository like Bintray (as I did with my own projectsd) because you probably should (must?) be the one enabling Travis-CI for the ModelDriven organization on GitHub and crfeating the project on Bintray. |
|
@seidewitz Please see final changes just committed, which include sections for the README.md file. Also, this still does not clobber the existing archives you have been creating by hand, but instead produces the packages using a Any further questions, please let me know. |
- Also made some Eclipse config changes.
2 participants
This is work-in-progress for Issue #76, please do not merge, sharing partial progress for feedback.
iswas one test failing, but that was the case already in master (this change from January changed how resolveModelFile() works for files with errors, so it now returns a UnitDefinition even if there are errors, as the testexpectsexpected a null UnitDefinition to be returned,which I guess is - and maybe already was - an invalid expectation).I changed the test so it expects a non-null result.