fix: ignore docs, tests, and tutorials in Ray uploads#1787
fix: ignore docs, tests, and tutorials in Ray uploads#1787nightcityblade wants to merge 1 commit intoNVIDIA-NeMo:mainfrom
Conversation
Signed-off-by: nightcityblade <nightcityblade@gmail.com>
Greptile SummaryThis PR adds a
Confidence Score: 5/5Safe to merge — config-only change with no runtime risk. This is a single, config-only file addition. The No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant Ray as Ray CLI / SDK
participant Cluster as Ray Cluster
Dev->>Ray: ray job submit --working-dir .
Ray->>Ray: Read .rayignore
Ray->>Ray: Exclude docs/, tests/, tutorials/
Ray->>Cluster: Upload nemo_curator/ + remaining files
Cluster->>Cluster: Run pipeline
Reviews (1): Last reviewed commit: "fix: ignore docs, tests, and tutorials i..." | Re-trigger Greptile |
| docs/ | ||
| tests/ | ||
| tutorials/ |
There was a problem hiding this comment.
Consider also excluding
benchmarking/
The top-level benchmarking/ directory is not excluded. Like docs/ and tutorials/, it is unlikely to be needed at runtime on a Ray cluster and could be excluded to further reduce upload size.
| docs/ | |
| tests/ | |
| tutorials/ | |
| benchmarking/ | |
| docs/ | |
| tests/ | |
| tutorials/ |
Description
closes #1337
Add a
.rayignorefile so Ray uploads skip the docs, tests, and tutorials directories that do not need to be shipped with pipeline code.Usage
# No code changes required. Ray now respects .rayignore when packaging the working directory.Checklist