Fix #1531 (remove stray skip_reasons code)#1532
Merged
rwgk merged 3 commits intoNVIDIA:mainfrom Jan 26, 2026
Merged
Conversation
Deduplicate root-only devices while preserving order.
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Collaborator
Author
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
Contributor
|
Simplified this -- there is no need to try on multiple devices, since we don't test on systems with devices of different architecture generations, and if we ever come across a system like that, we will get a warning: https://github.com/NVIDIA/cuda-python/blob/main/cuda_bindings/tests/nvml/test_init.py#L20 |
Contributor
|
/ok to test |
mdboom
approved these changes
Jan 26, 2026
rwgk
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1531
Deduplicate root-only devices while preserving order.