refactor(pathfinder): privatize optional_cuda_import#1742
Merged
cpcloud merged 3 commits intoNVIDIA:mainfrom Mar 9, 2026
Merged
refactor(pathfinder): privatize optional_cuda_import#1742cpcloud merged 3 commits intoNVIDIA:mainfrom
optional_cuda_import#1742cpcloud merged 3 commits intoNVIDIA:mainfrom
Conversation
Rename `optional_cuda_import` to `_optional_cuda_import` to remove it from the public API surface. It is an internal helper used only by `cuda.core` and should not be part of the stable public interface. Made-with: Cursor
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
leofang
approved these changes
Mar 9, 2026
| Python modules. It returns ``None`` when the requested module is absent or a | ||
| probe hits ``DynamicLibNotFoundError``, while still re-raising unrelated | ||
| ``ModuleNotFoundError`` exceptions (for missing transitive dependencies). | ||
| * Add ``_optional_cuda_import()`` (private helper) to support robust optional |
Member
There was a problem hiding this comment.
Q: If it's private do we still want to document it?
leofang
added
the
cuda.pathfinder
Made-with: Cursor
Contributor
Author
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
The re-export shadowed the `_optional_cuda_import` submodule with the function of the same name, breaking `import ... as` in tests. Import directly from the submodule in consumers instead. Made-with: Cursor
Contributor
Author
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
optional_cuda_importto_optional_cuda_importto remove it from the public API surface, since it is an internal helper used only bycuda.core.cuda_core(_linker.pyx,_program.pyx) and their tests to use the private name.optional_cuda_importfrom the Sphinx API docs.Test plan
test_optional_cuda_import.pytests pass (pathfinder)test_optional_dependency_imports.pytests pass (cuda_core)Made with Cursor