Skip to content

Preserve skill selection on character reimport#9486

Merged
Wires77 merged 11 commits intoPathOfBuildingCommunity:devfrom
mcagnion:feature/keep-active-and-full-dps-skills
Apr 15, 2026
Merged

Preserve skill selection on character reimport#9486
Wires77 merged 11 commits intoPathOfBuildingCommunity:devfrom
mcagnion:feature/keep-active-and-full-dps-skills

Conversation

@mcagnion
Copy link
Copy Markdown
Contributor

@mcagnion mcagnion commented Feb 25, 2026

Fixes #8210.
Fixes #8742.

Description of the problem being solved:

When re-importing a character build (especially with "Clear Skills" enabled), Path of Building rebuilds socket groups from imported items/gems but can lose user-selected state for matching groups. This can clear Include in Full DPS, change the active skill selection, or reset multipart / stage / mine sub-state on supported skills.

Steps taken to verify a working solution:

  • Preserved a non-default main socket group and active skill on reimport.
  • Preserved Include in Full DPS on matching socket groups.
  • Preserved disabled active/support gems on reimport.
  • Preserved skillPart, skillStageCount, and skillMineCount on supported skills.
  • Reimport still completed successfully when socket groups and gems changed.

@mateokladaric
Copy link
Copy Markdown

Fixes #8742 as well

@Wires77 Wires77 force-pushed the feature/keep-active-and-full-dps-skills branch from a09023d to 5c4b39a Compare April 15, 2026 04:29
Copy link
Copy Markdown
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I added a few more things to preserve on re-import. Thanks for adding the tests!

@Wires77 Wires77 merged commit f717d7d into PathOfBuildingCommunity:dev Apr 15, 2026
3 checks passed
@Wires77 Wires77 added enhancement New feature, calculation, or mod pob2 Label for features that should be ported over to PoB-PoE2 labels Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod pob2 Label for features that should be ported over to PoB-PoE2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DPS calculation disappears after 2nd import to build "Include in Full DPS" incorrectly showing as enabled after re-import for SRS

3 participants