Preserve skill selection on character reimport#9486
Merged
Wires77 merged 11 commits intoPathOfBuildingCommunity:devfrom Apr 15, 2026
Merged
Preserve skill selection on character reimport#9486Wires77 merged 11 commits intoPathOfBuildingCommunity:devfrom
Wires77 merged 11 commits intoPathOfBuildingCommunity:devfrom
Conversation
2 tasks
|
Fixes #8742 as well |
a09023d to
5c4b39a
Compare
Wires77
approved these changes
Apr 15, 2026
Member
Wires77
left a comment
There was a problem hiding this comment.
Looks good, I added a few more things to preserve on re-import. Thanks for adding the tests!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8210.
Fixes #8742.
Description of the problem being solved:
When re-importing a character build (especially with "Clear Skills" enabled), Path of Building rebuilds socket groups from imported items/gems but can lose user-selected state for matching groups. This can clear
Include in Full DPS, change the active skill selection, or reset multipart / stage / mine sub-state on supported skills.Steps taken to verify a working solution:
Include in Full DPSon matching socket groups.skillPart,skillStageCount, andskillMineCounton supported skills.