Fix Cruelty from Bitter Lash Bloodline not applying to main hand skills#9619
Merged
LocalIdentity merged 1 commit intodevfrom Mar 14, 2026
Merged
Fix Cruelty from Bitter Lash Bloodline not applying to main hand skills#9619LocalIdentity merged 1 commit intodevfrom
LocalIdentity merged 1 commit intodevfrom
Conversation
The parsing for the mod was not converting the `main hand weapon` mod text into slot = "Weapon 1" so it would parse but not actually work
NDari
pushed a commit
to NDari/PathOfBuilding
that referenced
this pull request
Mar 31, 2026
…ls (PathOfBuildingCommunity#9619) The parsing for the mod was not converting the `main hand weapon` mod text into slot = "Weapon 1" so it would parse but not actually work Co-authored-by: LocalIdentity <localidentity2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
The parsing for the mod was not converting the
main hand weaponmod text into slot = "Weapon 1" so it would parse but not actually workAlso fixes the parsing for the slot name variable, as it was using itemSlotName by mistake
Link to a build that showcases this PR:
https://maxroll.gg/poe/pob/na27300o
Before screenshot:
After screenshot: