Add support for Imbued Supports#9670
Conversation
…e else because it's an infestation
…s an imbued don't show imbued label/dropdown for skills from items
update scrollBar in SkillsTab to fit imbued change Clear button to X design of the other gems
|
I found a few issues. (sorry) The hover tooltip on the imbued shows the tooltip for the second gem in the socket group. Whether it be a support or an active gem. If there is no second gem, no tooltip pops up. Opening the Imbued selection then clicking away to close it, will cause the imbued select to change to the top most support, instead of reverting to the current selected gem. Related to the first two, the tooltip does not show on Import until a change is made (quality, count, new gem, etc). Then it will follow the logic above. Typing to search for the gems is different than the normal dropdowns. I can't type "spell" to have spell echo show up. With Fireball as the skill. I type s, it auto fills with Sacrifice. Then, any further letters are added onto that gem name, so "Sacrificepell". If you backspace to remove the text, once it's fully erased, backspacing again will show the hex color code. |
…lor, click away from dropdown fix
Wires77
left a comment
Wires77
left a comment
There was a problem hiding this comment.
- The dropdown should be moved under "Socketed In:" for portrait mode users.
- Tooltip suggestion:
"Socketed in" must be set...or"Socketed in" item must be setto make it clear you're talking about a UI item - You could restrict the dropdown to only show the support gems that would receive a checkmark, since only those are explicitly allowed
This otherwise looks pretty good, any reason for using colorCodes.POSITIVE instead of colorCodes.CRAFTED to better match in-game?
fix - disable remove button on disabled imbued socketGroup
|
Updated everything except for restricting the dropdown. Trickier so far than I expected. Also fixed an issue with the clear X button on a disabled imbued socketGroup wasn't disabled which caused some tomfoolery. Updated UI look, lined up pretty well |
Remove gems from the list that cannot support the active skill Adds code in calc tools to grab the skillTypes from the base skill so any added skill types are ignored
Cherrypicked from #9670 to make the diff from that PR cleaner
* Remove Quality type dropdown Cherrypicked from #9670 to make the diff from that PR cleaner * Remove more quality stuff * Last quality fix * Remove quality types from export * Remove dummy stat quality export --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Importing a skill gem that has an imbued support for a different gear slot would override the existing gems in the build
Setting a imbued gem on a skill set would block all the other skill sets from also setting a gem for the same item slot
Using something like Forbidden Shako was having the support gems from the helmet apply to active skills granted by the helmet when they are not meant to apply
The sortCache now only runs on non-exceptional supports to loads a lot faster when clicked
The buttons for sorting by support or active skill gem were invisible for the imbued box but still applying if clicked. Now they do not apply when clicking in that area
3 participants
Description of the problem being solved:
Full implementation of Imbued Supports, including Importing from Character, Saving and Loading to the XML, and fixing "too many gems in slot" warning. The selection automatically filters for Level 1 Non-Exceptional Support gems. The colour of "Imbued Support:" will follow the application options Positive Values Hex colour.
You are only allowed one imbued support per Slot.
PS: This PR also removes the Variant column in the skillsTab. It happened long enough ago I forgot it was in this branch. If you don't want it in this change, let me know.
After screenshot: