Skip to content

Fix Maven Memory Game damage#9757

Open
LocalIdentity wants to merge 1 commit intodevfrom
fix_maven-memory-gamge-damage
Open

Fix Maven Memory Game damage#9757
LocalIdentity wants to merge 1 commit intodevfrom
fix_maven-memory-gamge-damage

Conversation

@LocalIdentity
Copy link
Copy Markdown
Contributor

Fixes #9756

Description of the problem being solved:

At the start of 3.27 they added a new physical damage conversion multiplier. I added support for boss skills to be correctly scaled but didn't realise that we had hardcoded some boss values that were not being pulled from the game files
The Maven Memory Game attack had its base damage effectiveness go from 12.5 in 3.26 to 3.125 in 3.27 but cause we were not exporting the skill from the game files, it just had 300% more damage from the conversion multi mod

We should really have all boss skills exported from the game files. I really do not like how we currently export them as believe that it would be far better to export the monster and their skills similarly to how we have spectres and minions

Before screenshot:

image

After screenshot:

image

The damage for the skill was not corrected when I added support for the phys as extra damage multi for enemies
@LocalIdentity LocalIdentity added the bug: calculation Numerical differences label Apr 14, 2026
@StDogbert
Copy link
Copy Markdown

StDogbert commented Apr 14, 2026

Thx a ton! Thought I was going insane for last few leagues looking at maven memory game.
+1 for getting rid of magic numbers in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: calculation Numerical differences

Projects

None yet

2 participants