Fix typos in resource strings and associated C# references#2163
Open
casuffitsharp wants to merge 2 commits intoPowerShell:mainfrom
Open
Fix typos in resource strings and associated C# references#2163casuffitsharp wants to merge 2 commits intoPowerShell:mainfrom
casuffitsharp wants to merge 2 commits intoPowerShell:mainfrom
Conversation
- Correct misspellings in Strings.resx (e.g., 'equaltiy', 'whitepsace') - Rename misspelled resource keys for consistency - Update C# rule files to reflect new resource key names
Author
@microsoft-github-policy-service agree |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up user-facing rule resource strings by correcting typos/grammar and aligns C# rule implementations to renamed .resx resource keys so the strongly-typed Strings references continue to compile.
Changes:
- Fixed multiple typos/wording issues in
Rules/Strings.resx. - Renamed misspelled resource keys to correctly spelled names.
- Updated C# rule files to reference the new resource key/property names.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Rules/UseShouldProcessForStateChangingFunctions.cs | Updates Strings.* reference to the corrected ...Description resource key. |
| Rules/UseLiteralInitializerForHashtable.cs | Replaces misspelled resource property names with corrected UseLiteralInitializer... keys. |
| Rules/PossibleIncorrectComparisonWithNull.cs | Updates to the corrected ...SuggestedCorrectionDescription resource key. |
| Rules/Strings.resx | Fixes typos/grammar in values and renames several misspelled resource keys. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Combine sentence fragment in AvoidUsingEmptyCatchBlockDescription for better flow - Update 'Whatif' to 'WhatIf' in UseSupportsShouldProcess strings to match PowerShell naming conventions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR fixes several typos and grammatical errors identified in the Rules/Strings.resx file. It also renames resource keys that contained misspellings. Corresponding references in C# rule files have been updated to maintain build stability.
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.