Skip to content

Fix typos in resource strings and associated C# references#2163

Open
casuffitsharp wants to merge 2 commits intoPowerShell:mainfrom
casuffitsharp:main
Open

Fix typos in resource strings and associated C# references#2163
casuffitsharp wants to merge 2 commits intoPowerShell:mainfrom
casuffitsharp:main

Conversation

@casuffitsharp
Copy link

@casuffitsharp casuffitsharp commented Mar 8, 2026

  • Correct misspellings in Strings.resx (e.g., 'equaltiy', 'whitepsace')
  • Rename misspelled resource keys for consistency
  • Update C# rule files to reflect new resource key names

PR Summary

This PR fixes several typos and grammatical errors identified in the Rules/Strings.resx file. It also renames resource keys that contained misspellings. Corresponding references in C# rule files have been updated to maintain build stability.

PR Checklist

- Correct misspellings in Strings.resx (e.g., 'equaltiy', 'whitepsace')
- Rename misspelled resource keys for consistency
- Update C# rule files to reflect new resource key names
Copilot AI review requested due to automatic review settings March 8, 2026 04:16
@casuffitsharp casuffitsharp requested review from a team and bergmeister as code owners March 8, 2026 04:16
@casuffitsharp
Copy link
Author

@casuffitsharp please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up user-facing rule resource strings by correcting typos/grammar and aligns C# rule implementations to renamed .resx resource keys so the strongly-typed Strings references continue to compile.

Changes:

  • Fixed multiple typos/wording issues in Rules/Strings.resx.
  • Renamed misspelled resource keys to correctly spelled names.
  • Updated C# rule files to reference the new resource key/property names.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
Rules/UseShouldProcessForStateChangingFunctions.cs Updates Strings.* reference to the corrected ...Description resource key.
Rules/UseLiteralInitializerForHashtable.cs Replaces misspelled resource property names with corrected UseLiteralInitializer... keys.
Rules/PossibleIncorrectComparisonWithNull.cs Updates to the corrected ...SuggestedCorrectionDescription resource key.
Rules/Strings.resx Fixes typos/grammar in values and renames several misspelled resource keys.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Combine sentence fragment in AvoidUsingEmptyCatchBlockDescription for better flow
- Update 'Whatif' to 'WhatIf' in UseSupportsShouldProcess strings to match PowerShell naming conventions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants