feat: integrate FP8 weight transfer format#2038
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| "When disabled, uses default HF checkpoint-format transfer." | ||
| ), | ||
| ), | ||
| ] = False |
There was a problem hiding this comment.
Missing CHANGELOG entry for new config field
Low Severity
A new quantize_in_weight_transfer config field is added to NCCLWeightBroadcastConfig in the orchestrator, trainer, and RL config files, as well as SharedWeightBroadcastConfig, but CHANGELOG.md has no corresponding entry. This violates the rule requiring changelog updates when configuration structures are modified.
Additional Locations (2)
Triggered by project rule: BugBot Instructions
samsja
reviewed
Mar 19, 2026
samsja
reviewed
Mar 20, 2026
samsja
reviewed
Mar 21, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Note
Medium Risk
Adds a new NCCL weight transfer mode that changes the on-the-wire weight format and in-place loading behavior in vLLM workers, which could break updates for unsupported models or mismatched tensor shapes. Guardrails/validators reduce misconfiguration risk but correctness depends on model-specific conversion logic.
Overview
Adds an opt-in
quantize_in_weight_transferflag for NCCL weight broadcast across sharedRLConfig,TrainerConfig, andOrchestratorConfig, and wires it through orchestrator → HTTP/init_broadcaster→ vLLM worker initialization.When enabled, the trainer broadcasts vLLM kernel-format FP8 (e4m3) weights instead of HF checkpoint-format tensors, using new per-layer conversion (
PreTrainedModelPrimeRL.convert_layer_to_vllm_kernel) and FP8 blockwise quantization utilities. The inference-side NCCL worker now selects between checkpoint loading and a new kernel-mode in-place copy loader (weight_transfer.py) with extra post-processing for certain kernels (e.g., MLA absorbed KV weights).Also tightens config behavior: validates that quantized transfer is only used with
weight_broadcast.type='nccl', with inference configured, and withtrainer.model.impl='custom', and adjusts shared model name propagation/validation to keep inference and orchestrator model names consistent.Written by Cursor Bugbot for commit a997302. This will update automatically on new commits. Configure here.