Plot improvements: DPI config, Delaunay aspect ratio, tick rounding, source vmax#244
Merged
Plot improvements: DPI config, Delaunay aspect ratio, tick rounding, source vmax#244
Conversation
…source vmax - Add `dpi` key to `visualize/general.yaml` (default 150) so save_figure reads DPI from config rather than hardcoding 300 - Fix Delaunay source-plane aspect ratio to match rectangular: pass extent to _plot_delaunay and call ax.set_aspect(x_range/y_range, adjustable="box") - Fix tick-label 1e-16 noise: after rounding, clamp values < 1e-10 of scale to zero in _round_ticks so symmetric extents don't show scientific notation - Add vmin/vmax parameters to plot_mapper, forwarded to plot_inversion_reconstruction - In subplot_of_mapper, compute recon_vmax from the reconstructed image and pass to both source-plane panels so Zoom and No-Zoom share a colorbar scale Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dpikey tovisualize/general.yaml(default 150) sosave_figurereads DPI from config rather than hardcoding 300, halving output file sizes with negligible quality lossextentto_plot_delaunayand callax.set_aspect(x_range/y_range, adjustable="box")1e-16noise on both rectangular and Delaunay panels: after rounding, clamp values smaller than1e-10of scale to zero in_round_ticksso symmetric extents don't display scientific notationvmin/vmaxparameters toplot_mapper, forwarded toplot_inversion_reconstructionsubplot_of_mapper, computerecon_vmaxfrom the reconstructed image and pass to both source-plane panels (Zoom and No-Zoom) so they share a consistent colorbar scaleTest plan
scripts/imaging/visualization.py— checkfit.pngandinversion_0_0.pngsource-plane panels share colorbar with Data (Source Scale)🤖 Generated with Claude Code