Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1011 +/- ##
==========================================
+ Coverage 80.75% 80.77% +0.01%
==========================================
Files 198 198
Lines 14979 14983 +4
==========================================
+ Hits 12096 12102 +6
+ Misses 2883 2881 -2 ☔ View full report in Codecov by Sentry. |
VascoSch92
reviewed
Apr 24, 2024
Comment on lines
+14
to
+15
| Graphical models concisely describe these model and dataset dependencies and allow for | ||
| them to be fitted simultaneously, with a concise API and scientific workflow that ensures scalability to big datasets. |
There was a problem hiding this comment.
Suggested change
| Graphical models concisely describe these model and dataset dependencies and allow for | |
| them to be fitted simultaneously, with a concise API and scientific workflow that ensures scalability to big datasets. | |
| Graphical models concisely describe these model and dataset dependencies, allowing them to be fitted simultaneously. This is achieved through a concise API and scientific workflow that ensures scalability to large datasets. |
VascoSch92
reviewed
Apr 24, 2024
| The parameters of this parent distribution are themselves inferred from the data, which for many problems enables | ||
| more robust and informative model fitting. | ||
|
|
||
| Anfull description of using hierarchical models is given below: |
There was a problem hiding this comment.
Suggested change
| Anfull description of using hierarchical models is given below: | |
| A full description of using hierarchical models is given below: | |
VascoSch92
reviewed
Apr 24, 2024
| Hierarchical Models | ||
| ------------------- | ||
|
|
||
| Hierarchical models are where multiple parameters in the model are assumed to be drawn from a common distributio. |
There was a problem hiding this comment.
Suggested change
| Hierarchical models are where multiple parameters in the model are assumed to be drawn from a common distributio. | |
| Hierarchical models are where multiple parameters in the model are assumed to be drawn from a common distribution. |
VascoSch92
reviewed
Apr 24, 2024
Comment on lines
+25
to
+26
| The parameters of this parent distribution are themselves inferred from the data, which for many problems enables | ||
| more robust and informative model fitting. |
There was a problem hiding this comment.
Suggested change
| The parameters of this parent distribution are themselves inferred from the data, which for many problems enables | |
| more robust and informative model fitting. | |
| The parameters of this parent distribution are themselves inferred from the data, , enabling more robust and informative model fitting for many problems. |
VascoSch92
reviewed
Apr 24, 2024
| Search Grid Search | ||
| ------------------ | ||
|
|
||
| A classic method to perform model-fitting is a grid search, where the parameters of a model are divided on to a grid of |
There was a problem hiding this comment.
Suggested change
| A classic method to perform model-fitting is a grid search, where the parameters of a model are divided on to a grid of | |
| A classic method to perform model-fitting is a grid search, where the parameters of a model are divided onto a grid of | |
Collaborator
Author
There was a problem hiding this comment.
Thanks for all the suggestions! Implemented :)
rhayes777
approved these changes
Apr 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation on building a scientific workflow.